add case for file backed nvdimm memory lifecycle #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanli1
force-pushed
the
add_case_for_file_backed_nvdimm_lifecycle
branch
2 times, most recently
from
15f25da to
394a519
Compare
smitterl
suggested changes
Jan 13, 2024
|
|
||
| save_file = params.get("save_file") | ||
| if os.path.exists(save_file): | ||
| os.remove(save_file) |
There was a problem hiding this comment.
I think you should better assume that the file doesn't exist when the test starts but make sure to remove it during teardown.
There was a problem hiding this comment.
Hi Sebas , Thanks for your comment. If other cases have the same named file left, m which will influence my test
| nvdimm_dict = {'mem_model':'nvdimm', 'mem_access':'${access}',${source_attrs},${target_attrs} } | ||
| variants: | ||
| - with_numa: | ||
| no s390-virtio |
There was a problem hiding this comment.
Actually, you could define no s390-virtio on the top level because there's no NVDIMM on s390x.
|
|
||
| def run_test(): | ||
| """ | ||
| 1.Define vm with nvdimm memory device and check nvdimm config. |
There was a problem hiding this comment.
I think the comments need some cleanup, I propose:
1. Define a vm with a nvdimm memory device and check the nvdimm configuration.
2. Hotplug an nvdimm memory device and check the nvdimm configuration.
3. Check the alignment with the virsh qemu-monitor-command.
4. Create a file system on two nvdimm devices in the guest.
6. Lifecycle checks for a guest with an attached device.
7. Hotplug an nvdimm device.
| 3.Check the alignment by virsh qemu-monitor-command. | ||
| 4.Create file system on two nvdimm device in guest. | ||
| 6.Liefycle for guest. | ||
| 7.Hotplug a nvdimm. |
There was a problem hiding this comment.
Is this a second device? Is 7. the same as 2.?
nanli1
force-pushed
the
add_case_for_file_backed_nvdimm_lifecycle
branch
2 times, most recently
from
d9a8690 to
434780c
Compare
nanli1
force-pushed
the
add_case_for_file_backed_nvdimm_lifecycle
branch
3 times, most recently
from
b266a4b to
3d988cc
Compare
VIRT-299192: Life cycle of file backed nvdimm memory device Signed-off-by: nanli <[email protected]>
nanli1
force-pushed
the
add_case_for_file_backed_nvdimm_lifecycle
branch
from
3d988cc to
fa34e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nanli [email protected]
x86+rhel9
aarch+rhel9