Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virsh dump memory-only format kdump-* failure #5409

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Fix virsh dump memory-only format kdump-* failure #5409

merged 1 commit into from
Jan 28, 2024

Conversation

misanjumn
Copy link
Contributor

@misanjumn misanjumn commented Jan 25, 2024 •
edited
Loading

Fix virsh dump memory-only format kdump-* failure

Since linux command 'file <file_name>' version 5.44, the memory-only dump formats:
kdump-zlib, kdump-lzo and kdump-snappy are taken as 'flattened kdump compressed
dump'
Source: file-command-flattened-kdump-compress
In older 'file' version < 5.44 the same dump formats are taken as 'data'
This is leading to the failure of tests 11 and 28 in ras bucket

Signed-off-by: Misbah Anjum N [email protected]

@misanjumn
Fix virsh dump memory-only format kdump-* failure
d48a87d 
Since linux command 'file <file_name>' version 5.44,
the memory-only dump formats: kdump-zlib, kdump-lzo and
kdump-snappy are taken as 'flattened kdump compressed
dump'

In older 'file' version < 5.44 the same dump formats are
taken as 'data'

Updated virsh_dump.py to support the change in the format
and fix the failure.

Signed-off-by: Misbah Anjum N <[email protected]>
@misanjumn
Copy link
Contributor Author

Running ras.cfg in avocado-vt

In new file version (>=5.44) - FAILURE

# file --version
file-5.44

Test: [11] FAIL
avocado.job testlogs         L0132 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.non_acl.memory_dump.kdump-zlib_format: STARTED
avocado.job testlogs         L0138 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.non_acl.memory_dump.kdump-zlib_format: FAIL

Test: [28] FAIL
avocado.job testlogs         L0132 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.acl_test.memory_dump.kdump-zlib_format: STARTED
avocado.job testlogs         L0138 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.acl_test.memory_dump.kdump-zlib_format: FAIL

Same for [11] and [28]
INFO | Running 'file /home/vm.core'
DEBUG| [stdout] /home/vm.core: Flattened kdump compressed dump v100663296, machine Unknown
INFO | Command 'file /home/vm.core' finished with 0 after 0.005115590s
DEBUG| Run file /home/vm.core output: /home/vm.core: Flattened kdump compressed dump v100663296, machine Unknown
ERROR| Compress dumped file to data fail: Flattened

In old file version (<5.44) - PASS

# file --version
file-5.39

Test: [11] PASS
avocado.job testlogs         L0132 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.non_acl.memory_dump.kdump-zlib_format: STARTED
avocado.job testlogs         L0138 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.non_acl.memory_dump.kdump-zlib_format: PASS

Test: [28] PASS
avocado.job testlogs         L0132 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.acl_test.memory_dump.kdump-zlib_format: STARTED
avocado.job testlogs         L0138 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.acl_test.memory_dump.kdump-zlib_format: PASS

Same for [11] and [28]
INFO | Running 'file /home/vm.core'
DEBUG| [stdout] /home/vm.core: data
INFO | Command 'file /home/vm.core' finished with 0 after 0.003406823s
DEBUG| Run file /home/vm.core output: /home/vm.core: data
INFO | Successfully dump domain to /home/vm.core

After the commit - PASS

# file --version
file-5.44

Test: [11] PASS
avocado.job testlogs         L0132 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.non_acl.memory_dump.kdump-zlib_format: STARTED
avocado.job testlogs         L0138 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.non_acl.memory_dump.kdump-zlib_format: PASS

Test: [28] PASS
avocado.job testlogs         L0132 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.acl_test.memory_dump.kdump-zlib_format: STARTED
avocado.job testlogs         L0138 INFO | type_specific.io-github-autotest-libvirt.virsh.dump.positive_test.acl_test.memory_dump.kdump-zlib_format: PASS

Same for [11] and [28]
INFO | Running 'file /home/vm.core'
DEBUG| [stdout] /home/vm.core: Flattened kdump compressed dump v100663296, machine Unknown
INFO | Command 'file /home/vm.core' finished with 0 after 0.008489911s
DEBUG| Run file /home/vm.core output: /home/vm.core: Flattened kdump compressed dump v100663296, machine Unknown
INFO | Successfully dump domain to /home/vm.core

dzhengfy
dzhengfy approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@dzhengfy dzhengfy merged commit 61bf684 into autotest:master Jan 28, 2024
5 checks passed
@misanjumn
Copy link
Contributor Author

LGTM. Thanks for the fix.

You're most welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhengfy dzhengfy dzhengfy approved these changes

Assignees
No one assigned
Labels
minorfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misanjumn @dzhengfy