Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maxvcpu increase makes the case checking maxvcpu failed #6059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nanli1
Copy link
Contributor

@nanli1 nanli1 commented Dec 12, 2024

Update two cases

  • ioapic_iommu case: maxvxpu num changes from 710 to 2096
  • no_iommu case: automatically configure iommu (if it is missing) in the right way if a user
    requests >255 CPUs. Source defect xxxx -65844 - this would be positive scenario , because the ioapic would be added automatically

Signed-off-by: nanli [email protected]

Before fixed

 avocado run --vt-type libvirt --vt-omit-data-loss --vt-machine-type q35 max_vcpus.negative_test.ioapic_iommu --vt-connect-uri qemu:///system

 (1/1) type_specific.io-github-autotest-libvirt.max_vcpus.negative_test.ioapic_iommu: FAIL: Expect should fail with one of unsupported configuration: Maximum CPUs greater than specified machine type limit|exceeds the maximum cpus supported, but succeeded: Domain 'avocado-vt-vm1' defined from /var/tmp/xml_utils_temp_7kyym6dk.xml\n\n\n (6.16 s)

avocado run --vt-type libvirt --vt-omit-data-loss --vt-machine-type q35 max_vcpus.negative_test.no_iommu --vt-connect-uri qemu:///system
 (1/1) type_specific.io-github-autotest-libvirt.max_vcpus.negative_test.no_iommu: FAIL: Expect should fail with one of unsupported configuration: more than 255 vCPUs require extended interrupt mode enabled on the iommu device, but succeeded: Domain 'avocado-vt-vm1' defined from /var/tmp/xml_utils_temp_v5iyoaqy.xml\n\n\n (8.07 s)


After fixed

 avocado run --vt-type libvirt --vt-omit-data-loss --vt-machine-type q35 max_vcpus.negative_test.ioapic_iommu --vt-connect-uri qemu:///system

 (1/1) type_specific.io-github-autotest-libvirt.max_vcpus.negative_test.ioapic_iommu: PASS (5.92 s)

avocado run --vt-type libvirt --vt-omit-data-loss --vt-machine-type q35 max_vcpus.negative_test.no_iommu --vt-connect-uri qemu:///system
 (1/1) type_specific.io-github-autotest-libvirt.max_vcpus.negative_test.no_iommu: FAIL: Expect should succeed, but got: \n\nerror: Failed to define domain from /var/tmp/xml_utils_temp_almayp_e.xml\nerror: unsupported configuration: IOMMU interrupt remapping requires split I/O APIC (ioapic driver='qemu')\n (14.29 s)
this Would be PASS after bug xxxx-65844 fixed 

@nanli1 nanli1 force-pushed the fix_maxvxpu_increase_makes_the_case_checking_maxcpu_failed branch from da4435f to 96a75e7 Compare December 12, 2024 02:09
@nanli1 nanli1 marked this pull request as draft December 12, 2024 02:09
@nanli1 nanli1 force-pushed the fix_maxvxpu_increase_makes_the_case_checking_maxcpu_failed branch 4 times, most recently from d114229 to 63d1875 Compare December 18, 2024 07:09
 num changes from 710 to 2096
Signed-off-by: nanli <[email protected]>
@nanli1 nanli1 force-pushed the fix_maxvxpu_increase_makes_the_case_checking_maxcpu_failed branch from 63d1875 to 38831fb Compare December 18, 2024 07:29
@nanli1 nanli1 marked this pull request as ready for review December 18, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant