Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value 0 when specific cpu toplogy file is missing #6102

Conversation

liang-cong-red-hat
Copy link
Contributor

if specific cpu topology file from sysfs doesn't exist, defalut 0 would be used in virsh capabilities.
Depends on avocado-vt pr: avocado-framework/avocado-vt#4047

Test result:
(1/1) type_specific.io-github-autotest-libvirt.numa_capabilities.default: STARTED
(1/1) type_specific.io-github-autotest-libvirt.numa_capabilities.default: PASS (9.83 s)

@liang-cong-red-hat liang-cong-red-hat force-pushed the numa_capabilities_add_default_value branch from 9a8c88d to c614c2f Compare January 2, 2025 08:38
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

libvirt/tests/cfg/numa/numa_capabilities.cfg Outdated Show resolved Hide resolved
@liang-cong-red-hat liang-cong-red-hat force-pushed the numa_capabilities_add_default_value branch from c614c2f to 6d431df Compare January 6, 2025 07:48
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhengfy dzhengfy merged commit b8085b8 into autotest:master Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants