Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy v0.981 #67

Merged
merged 1 commit into from
May 14, 2024
Merged

Update mypy v0.981 #67

merged 1 commit into from
May 14, 2024

Conversation

w1mvy
Copy link
Contributor

@w1mvy w1mvy commented May 14, 2024

Description

Fixes #66

Update mypy to the corrected version mentioned on mypy side issue

$ make verify
black dbt_dry_run
All done! ✨ 🍰 ✨
56 files left unchanged.
black integration
All done! ✨ 🍰 ✨
12 files left unchanged.
isort dbt_dry_run
mypy dbt_dry_run
Success: no issues found in 56 source files
pytest --cov=dbt_dry_run
============================================================= test session starts =============================================================
platform darwin -- Python 3.11.7, pytest-7.4.4, pluggy-1.5.0
rootdir: /Users/xxx/go/src/github.com/autotraderuk/dbt-dry-run
configfile: pyproject.toml
testpaths: dbt_dry_run/test
plugins: cov-4.1.0, mock-3.14.0
collected 116 items

dbt_dry_run/test/test_columns_metadata.py ........                                                                                      [  6%]
dbt_dry_run/test/test_execution.py ............                                                                                         [ 17%]
dbt_dry_run/test/test_literals.py ........x........x                                                                                    [ 32%]
dbt_dry_run/test/test_result_reporter.py ...                                                                                            [ 35%]
dbt_dry_run/test/test_scheduler.py .......                                                                                              [ 41%]
dbt_dry_run/test/linting/test_column_linting.py ....                                                                                    [ 44%]
dbt_dry_run/test/models/test_manifest.py ......                                                                                         [ 50%]
dbt_dry_run/test/models/test_profile.py ...                                                                                             [ 52%]
dbt_dry_run/test/node_runner/test_incremental_runner.py ......................                                                          [ 71%]
dbt_dry_run/test/node_runner/test_node_runner.py ..                                                                                     [ 73%]
dbt_dry_run/test/node_runner/test_seed_runner.py ....                                                                                   [ 76%]
dbt_dry_run/test/node_runner/test_snapshot_runner.py .........                                                                          [ 84%]
dbt_dry_run/test/node_runner/test_source_runner.py .                                                                                    [ 85%]
dbt_dry_run/test/node_runner/test_table_runner.py ....                                                                                  [ 88%]
dbt_dry_run/test/node_runner/test_test_runner.py ...                                                                                    [ 91%]
dbt_dry_run/test/node_runner/test_view_runner.py .....                                                                                  [ 95%]
dbt_dry_run/test/sql_runner/test_big_query_sql_runner.py .....                                                                          [100%]

---------- coverage: platform darwin, python 3.11.7-final-0 ----------
Name                                             Stmts   Miss  Cover
--------------------------------------------------------------------
dbt_dry_run/__init__.py                              0      0   100%
dbt_dry_run/__main__.py                              5      5     0%
dbt_dry_run/adapter/__init__.py                      0      0   100%
dbt_dry_run/adapter/service.py                      50     18    64%
dbt_dry_run/adapter/utils.py                         3      1    67%
dbt_dry_run/cli.py                                  45     45     0%
dbt_dry_run/columns_metadata.py                     60      4    93%
dbt_dry_run/exception.py                            29      1    97%
dbt_dry_run/execution.py                            73     42    42%
dbt_dry_run/flags.py                                17      0   100%
dbt_dry_run/linting/__init__.py                      0      0   100%
dbt_dry_run/linting/column_linting.py               31      8    74%
dbt_dry_run/literals.py                             51      2    96%
dbt_dry_run/models/__init__.py                       4      0   100%
dbt_dry_run/models/manifest.py                     119     12    90%
dbt_dry_run/models/profile.py                       58      2    97%
dbt_dry_run/models/report.py                        24      0   100%
dbt_dry_run/models/table.py                         60      1    98%
dbt_dry_run/node_dispatch.py                        29     10    66%
dbt_dry_run/node_runner/__init__.py                 22      2    91%
dbt_dry_run/node_runner/incremental_runner.py      101      7    93%
dbt_dry_run/node_runner/node_test_runner.py         14      2    86%
dbt_dry_run/node_runner/seed_runner.py              29      1    97%
dbt_dry_run/node_runner/snapshot_runner.py          43      4    91%
dbt_dry_run/node_runner/source_runner.py            27      7    74%
dbt_dry_run/node_runner/table_runner.py             19      0   100%
dbt_dry_run/node_runner/view_runner.py              20      0   100%
dbt_dry_run/result_reporter.py                      73     21    71%
dbt_dry_run/results.py                              60      8    87%
dbt_dry_run/scheduler.py                            69     22    68%
dbt_dry_run/sql_runner/__init__.py                  21      5    76%
dbt_dry_run/sql_runner/big_query_sql_runner.py      58      5    91%
dbt_dry_run/version.py                               6      6     0%
--------------------------------------------------------------------
TOTAL                                             1220    241    80%


======================================================= 114 passed, 2 xfailed in 14.62s =======================================================
building coverage html
Wrote HTML report to htmlcov/index.html
make verify  16.27s user 3.13s system 48% cpu 40.162 total

dbt_dry_run/test/test_literals.py failed, but this test that has failed before.

Checklist:

  • I have run make verify and fixed any linting or test errors
  • I have added appropriate unit tests or if applicable an integration test
  • OPTIONAL: I have run make integration against a Big Query instance

@w1mvy w1mvy mentioned this pull request May 14, 2024
3 tasks
Copy link
Collaborator

@ccharlesgb ccharlesgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just managed to recreate this locally so this looks good πŸ‘

@ccharlesgb ccharlesgb merged commit dd42ae0 into autotraderuk:main May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed "make verify" in local
2 participants