Support python 3.12 version #72
Conversation
myouju
force-pushed
the
support-python-312-version
branch
from
9492b6a
to
df7feb7
Compare
|
sorry, not work with python3.12, so I close this. |
|
What was the error with 3.12? |
|
Here are some reasons for error.
Still trying, but not yet successful. |
|
The error has been resolved and I reopen this PR. |
pyproject.toml
Outdated
| agate = ">=1.7.0,<1.10" | ||
| google-cloud-bigquery = "^3" | ||
| pydantic = "^1.9.0" | ||
| tenacity = "^8.2" | ||
| networkx = ">=2.3,<4.0" | ||
| pyyaml = "~6" | ||
| typer = "~0" | ||
| numpy = [ |
There was a problem hiding this comment.
I don't think this package has a dependency on numpy or pandas directly. Should this be set in the dev dependencies instead?
There was a problem hiding this comment.
I was wrong, I'll set it up again in dev dependencies.
numpy 1.24 that has distutils doesn't support python 3.12 because we can't use distutils with python 3.12.
python 3.8 is supported by pandas up to 2.0.3.
We need to build pandas locally, because pandas for python3.12 does not exist in pypi with versions up to 2.1.0.
If we can accept local builds taking longer, no need to specify this. (In my environment it took 9 minutes.)
|
Thank you for your review and merging. |
Description
dbt-core v1.8 supports python 3.12 too.
Let's supported dbt-dry-run with 3.12.
We can also check test on multiple python version.
Checklist:
make verifyand fixed any linting or test errorsmake integrationagainst a Big Query instance