Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Istanbul open dataset #597

Merged
merged 7 commits into from
Oct 2, 2024
Merged

feat: add Istanbul open dataset #597

merged 7 commits into from
Oct 2, 2024

Conversation

ataparlar
Copy link
Contributor

@ataparlar ataparlar commented Aug 12, 2024

Description

An open urban dataset was created in Istanbul city. This PR is updating the Autoware Docs to add the dataset links and details to the related pages.
Related issue:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ataparlar ataparlar added type:documentation Creating or refining documentation. component:localization Vehicle's position determination in its environment. labels Aug 12, 2024
@ataparlar ataparlar self-assigned this Aug 12, 2024
@StepTurtle StepTurtle added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Aug 12, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Aug 12, 2024

@xmfcx
Copy link
Contributor

xmfcx commented Aug 12, 2024

Commit sha: [b8849ca](https://github.com/autowarefoundation/autoware-documentation/pull/597/commits/b8849ca457fe701d003ae172f74be6862b1585d4), Author: Ata Parlar, Committer: Ata Parlar; Expected "Ata Parlar [[email protected]](mailto:[email protected])", but got "Ata Parlar [[email protected]](mailto:[email protected])".

Could you add [email protected] to your github account as a secondary email?

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

docs/datasets/index.md Outdated Show resolved Hide resolved
docs/datasets/index.md Outdated Show resolved Hide resolved
@ataparlar ataparlar force-pushed the feat/add-ist-dataset branch 6 times, most recently from 837b7f7 to 4dce509 Compare August 12, 2024 14:40
@meliketanrikulu
Copy link
Contributor

@ataparlar Could you share your sensor_kit_launch and individual_params packages for testing with rosbag

@ataparlar
Copy link
Contributor Author

@meliketanrikulu sensor calibrations are available in the ‘/tf_static‘ topic. We didn't prepared a package for that.

@ataparlar ataparlar marked this pull request as draft August 14, 2024 15:05
@ataparlar
Copy link
Contributor Author

@meliketanrikulu noticed some time problem in the data. We will look into the problem. Converted the PR to the draft.

@meliketanrikulu
Copy link
Contributor

Bag file is updated and test process explained here --> https://github.com/orgs/autowarefoundation/discussions/5135

@meliketanrikulu
Copy link
Contributor

I updated imu msg 's angular and linear velocity fields in rosbag file. @ataparlar will test . Here is the new data. --> https://drive.google.com/drive/folders/17zXiBeYlM90gQ5hV6EAWaoBTnNFoVPML?usp=drive_link

Copy link
Contributor

@meliketanrikulu meliketanrikulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data is tested. Documentation checked. LGTM

@ataparlar ataparlar merged commit 934644b into main Oct 2, 2024
9 of 10 checks passed
@ataparlar ataparlar deleted the feat/add-ist-dataset branch October 2, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants