-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lidar_centerpoint)!: fix namespace and directory structure #8049
refactor(lidar_centerpoint)!: fix namespace and directory structure #8049
Conversation
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8049 +/- ##
========================================
Coverage 29.13% 29.13%
========================================
Files 1609 1635 +26
Lines 118141 118835 +694
Branches 50848 51057 +209
========================================
+ Hits 34419 34622 +203
- Misses 74494 74965 +471
- Partials 9228 9248 +20
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@MasatoSaeki |
@knzo25 |
@MasatoSaeki
|
Question: Since the package changed name, maybe Optional: Transfusion already addressed this, but the namespace for the previously called |
@knzo25
It is ok. I confirmed that to mot's code owner.
We need to handle this. So I will do later.
Either is good for me. If you recommend
It is true. Please wait a moment while I handle this. |
Signed-off-by: MasatoSaeki <[email protected]>
I changed namespace from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…utowarefoundation#8049) * add prefix in lidar_centerpoint Signed-off-by: MasatoSaeki <[email protected]> * add .gitignore Signed-off-by: MasatoSaeki <[email protected]> * change include package name in image_projection_based fusion Signed-off-by: MasatoSaeki <[email protected]> * fix Signed-off-by: MasatoSaeki <[email protected]> * change in codeowner Signed-off-by: MasatoSaeki <[email protected]> * delete package Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * solve conflict too Signed-off-by: MasatoSaeki <[email protected]> * fix include file Signed-off-by: MasatoSaeki <[email protected]> * fix typo in launch file Signed-off-by: MasatoSaeki <[email protected]> * add prefix in README Signed-off-by: MasatoSaeki <[email protected]> * fix bugs by conflict Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix * change namespace from to Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: MasatoSaeki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…utowarefoundation#8049) * add prefix in lidar_centerpoint Signed-off-by: MasatoSaeki <[email protected]> * add .gitignore Signed-off-by: MasatoSaeki <[email protected]> * change include package name in image_projection_based fusion Signed-off-by: MasatoSaeki <[email protected]> * fix Signed-off-by: MasatoSaeki <[email protected]> * change in codeowner Signed-off-by: MasatoSaeki <[email protected]> * delete package Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * solve conflict too Signed-off-by: MasatoSaeki <[email protected]> * fix include file Signed-off-by: MasatoSaeki <[email protected]> * fix typo in launch file Signed-off-by: MasatoSaeki <[email protected]> * add prefix in README Signed-off-by: MasatoSaeki <[email protected]> * fix bugs by conflict Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix * change namespace from to Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: MasatoSaeki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…utowarefoundation#8049) * add prefix in lidar_centerpoint Signed-off-by: MasatoSaeki <[email protected]> * add .gitignore Signed-off-by: MasatoSaeki <[email protected]> * change include package name in image_projection_based fusion Signed-off-by: MasatoSaeki <[email protected]> * fix Signed-off-by: MasatoSaeki <[email protected]> * change in codeowner Signed-off-by: MasatoSaeki <[email protected]> * delete package Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * solve conflict too Signed-off-by: MasatoSaeki <[email protected]> * fix include file Signed-off-by: MasatoSaeki <[email protected]> * fix typo in launch file Signed-off-by: MasatoSaeki <[email protected]> * add prefix in README Signed-off-by: MasatoSaeki <[email protected]> * fix bugs by conflict Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix * change namespace from to Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: MasatoSaeki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…utowarefoundation#8049) * add prefix in lidar_centerpoint Signed-off-by: MasatoSaeki <[email protected]> * add .gitignore Signed-off-by: MasatoSaeki <[email protected]> * change include package name in image_projection_based fusion Signed-off-by: MasatoSaeki <[email protected]> * fix Signed-off-by: MasatoSaeki <[email protected]> * change in codeowner Signed-off-by: MasatoSaeki <[email protected]> * delete package Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * solve conflict too Signed-off-by: MasatoSaeki <[email protected]> * fix include file Signed-off-by: MasatoSaeki <[email protected]> * fix typo in launch file Signed-off-by: MasatoSaeki <[email protected]> * add prefix in README Signed-off-by: MasatoSaeki <[email protected]> * fix bugs by conflict Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix * change namespace from to Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: MasatoSaeki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
Description
This PR puts headers in the
autoware
namespace.Additional works
Related links
Part of: autowarefoundation/autoware#4569
How was this PR tested?
Tested in a local recompute environment how to test.
And also tested
colcon test
. results is below.autoware_lidar_centerpoint
image_projection_based_fusion
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.