Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed a bug from autoware pointcloud merger #111

Merged

Conversation

anhnv3991
Copy link
Contributor

Description

  • In autoware_pointcloud_merger, when a downsampling resolution is specified, the autoware_pointcloud_divider is used to downsample the input PCD files. The downsampled files are stored in a directory named pointcloud_merger_tmp/pointcloud_map.pcd. After that, the pointcloud merger iterates on the segmented files and merge them to a single output PCD file. However, the merger only uses a filesystem::directory_iterator to iterate on the pointcloud_merger_tmp directory, so it will not be able to detect any PCD files because they are put under the pointcloud_map.pcd directory. This PR replaces directory_iterator by recursive_directory_iterator, thus fixes that problem.

Related links

None

Tests performed

  • Merged with downsampling resolution 0.2.

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@anhnv3991 anhnv3991 changed the title Fixed a bug from autoware pointcloud merger fix: fixed a bug from autoware pointcloud merger Sep 6, 2024
@anhnv3991 anhnv3991 enabled auto-merge (squash) September 9, 2024 14:02
@anhnv3991 anhnv3991 merged commit 272b036 into autowarefoundation:main Sep 10, 2024
24 checks passed
YoshihiroKogure pushed a commit to YoshihiroKogure/autoware_tools that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants