-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map): port lanelet2_map_preprocessor from autoware.universe #112
Merged
YamatoAndo
merged 5 commits into
autowarefoundation:main
from
a-maumau:mau/feat/lanelet2_map_utils
Sep 9, 2024
Merged
feat(map): port lanelet2_map_preprocessor from autoware.universe #112
YamatoAndo
merged 5 commits into
autowarefoundation:main
from
a-maumau:mau/feat/lanelet2_map_utils
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: a-maumau <[email protected]>
YamatoAndo
requested review from
RyuYamamoto,
anhnv3991,
YamatoAndo,
SakodaShintaro,
Motsu-san and
TaikiYamada4
September 6, 2024 09:05
YamatoAndo
reviewed
Sep 6, 2024
Signed-off-by: a-maumau <[email protected]>
YamatoAndo
reviewed
Sep 6, 2024
Signed-off-by: a-maumau <[email protected]> Co-authored-by: Yamato Ando <[email protected]>
Signed-off-by: a-maumau <[email protected]> Co-authored-by: Yamato Ando <[email protected]>
a-maumau
force-pushed
the
mau/feat/lanelet2_map_utils
branch
from
September 9, 2024 01:09
4c88e5a
to
2d22105
Compare
@YamatoAndo I applied your suggestions in 7b44197 and 2d22105 . |
Signed-off-by: a-maumau <[email protected]>
I change the |
YamatoAndo
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add
map/autoware_lanelet2_map_utils
which is a port ofautoware.universe/map/util/lanelet2_map_preprocessor
.After this PR, the
lanelet2_map_preprocessor
in the autoware.universe will be get removed and only the link to this package remains.Changes
autoware_lanelet2_map_utils
autoware_lanelet2_extension
tobuild_depends.repo
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.