Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driving_environment_analyzer): remove unused autoware_interpolation dependency #123

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Sep 20, 2024

Description

Follow up from:

There is no mention of the word "interpolation" within this package directory. I have doubts that this package uses this dependency.

Tests performed

Notes for reviewers

🚨 ⚠️ Must be merged after:

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx
Copy link
Contributor Author

xmfcx commented Sep 20, 2024

image

There is no mention of the word "interpolation" within this package directory. I have doubts that this package uses this dependency.

@satoshi-ota could you check if this package makes use of this dependency?

@xmfcx xmfcx force-pushed the refactor/prefix-interpolation branch from 210c24f to 14a93f0 Compare September 20, 2024 10:48
@xmfcx xmfcx changed the title refactor(driving_environment_analyzer): prefix interpolation with autoware in package.xml fix(driving_environment_analyzer): remove unused autoware_interpolation dependency Sep 20, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Sep 20, 2024

I've renamed this pr, removing this dependency, I don't think it's used. None of the headers are directly referenced from that package.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (ad0b811) to head (14a93f0).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #123      +/-   ##
========================================
- Coverage   2.12%   0.00%   -2.13%     
========================================
  Files        163       6     -157     
  Lines       9402     512    -8890     
  Branches     383       0     -383     
========================================
- Hits         200       0     -200     
+ Misses      9045     512    -8533     
+ Partials     157       0     -157     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx
Copy link
Contributor Author

xmfcx commented Sep 20, 2024

@satoshi-ota -san, could you review?

@xmfcx
Copy link
Contributor Author

xmfcx commented Sep 23, 2024

@satoshi-ota -san could you review please? It's a small PR.

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmfcx thanks!

@xmfcx xmfcx merged commit 3171e10 into main Sep 23, 2024
24 of 25 checks passed
@xmfcx xmfcx deleted the refactor/prefix-interpolation branch September 23, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants