-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(driving_environment_analyzer): remove unused autoware_interpolation dependency #123
Conversation
There is no mention of the word "interpolation" within this package directory. I have doubts that this package uses this dependency. @satoshi-ota could you check if this package makes use of this dependency? |
…on dependency Signed-off-by: M. Fatih Cırıt <[email protected]>
210c24f
to
14a93f0
Compare
I've renamed this pr, removing this dependency, I don't think it's used. None of the headers are directly referenced from that package. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
========================================
- Coverage 2.12% 0.00% -2.13%
========================================
Files 163 6 -157
Lines 9402 512 -8890
Branches 383 0 -383
========================================
- Hits 200 0 -200
+ Misses 9045 512 -8533
+ Partials 157 0 -157
☔ View full report in Codecov by Sentry. |
@satoshi-ota -san, could you review? |
@satoshi-ota -san could you review please? It's a small PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xmfcx thanks!
Description
Follow up from:
There is no mention of the word "interpolation" within this package directory. I have doubts that this package uses this dependency.
Tests performed
Notes for reviewers
🚨⚠️ Must be merged after:
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.