feat/serialization: add serialization #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobofan
force-pushed
the
feat/serialization
branch
8 times, most recently
from
31812f8
to
47f8d46
Compare
hobofan
changed the title
|
@MichaelHirn :) |
|
Thank you, @hobofan Are now all layers serializable? Also could you add a test/example of the serializing/deserializing a network? |
hobofan
force-pushed
the
feat/serialization
branch
from
47f8d46
to
df7c9d8
Compare
|
@MichaelHirn All layers are serializable, and I added a basic test of saving and loading, and a example for each. |
|
LGTM. Thank you for the update. Ready to merge |
|
@homu r+ |
|
📌 Commit df7c9d8 has been approved by |
|
⚡ Test exempted - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, the commit for deserialization is still missing because it needs a bit of polish
Will resolve #14, #15