Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dedupe basic API types from modality-mutator-protocol #22

Merged
merged 3 commits into from
Aug 31, 2023
Merged

dedupe basic API types from modality-mutator-protocol #22

merged 3 commits into from
Aug 31, 2023

Conversation

azdle
Copy link
Contributor

@azdle azdle commented Jan 25, 2023

This is technically a breaking change since AttrVal::String is changing from String to Cow<'static, str>, but I think it's minor enough of a change to be worth it.

-pub modality_api::AttrVal::String(alloc::string::String)
+pub modality_api::AttrVal::String(alloc::borrow::Cow<'static, str>)

@azdle azdle requested a review from ZackPierce January 25, 2023 17:08
@azdle azdle marked this pull request as draft January 25, 2023 18:38
@azdle azdle marked this pull request as ready for review January 25, 2023 19:29
@azdle azdle force-pushed the dedupe branch 2 times, most recently from bf25410 to f0ba174 Compare August 30, 2023 16:31
ZackPierce
ZackPierce approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@ZackPierce ZackPierce left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming minor cleanups and fixes occur, tests pass.

client-libraries/rust/modality-api/src/types.rs Outdated Show resolved Hide resolved
client-libraries/rust/modality-api/src/types.rs Outdated Show resolved Hide resolved
@azdle azdle merged commit c1a965c into main Aug 31, 2023
2 checks passed
@azdle azdle deleted the dedupe branch August 31, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackPierce ZackPierce ZackPierce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azdle @ZackPierce