-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACP 77 #2140
base: main
Are you sure you want to change the base?
ACP 77 #2140
Conversation
🔥 Just one high level comment: All L1s will still use Avalanche (technically Snowman++ consensus) for now. PoS vs PoA is just the mechanism for determining how validators are added/removed (ie. sybil resistance). Could we make that clear here by having the prompts ask for the "validator manager" type, rather than the "consensus" type? |
Will clarify the prompt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 makes sense to me, though we may want to wait to merge this until the value is actually used for the validator manager contract deployment.
Yup this will be the PR for all acp 77 pr to be merged into, will not be merged until acp 77 implementation is released in avalanchego |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a base branch
* prompt addresses * fix lint * fix lint * fix lint * fix lint * add flags * address comments * fix test * address comments * fix lint --------- Signed-off-by: sukantoraymond <[email protected]>
* prompt addresses * fix lint * fix lint * fix lint * fix lint * add flags * validator prompt * bootstrap validators * add mock * fix lint * update prompt validator * update prompt validator * implement prompts * fix prompt mock * update sidecar * update prompts * update prompts * refactor * update prompts * update prompts * use default balance and weight * generate new node ids and bls * fix lint * add flags * add flags * address comments * address comments * address comments * move validator prompt to deploy * address comments * address comments * fix lint * address comments * address comments * fix test * address comments * fix lint * address coments * address coments * fix test * fix test * fix test * fix lint --------- Signed-off-by: sukantoraymond <[email protected]>
* adding teleporter contract to genesis * fixes for icm on genesis * add icm from a given embedded file * add function to deploy ICM registry * creating mapping values * add consts * make local deploy to work * do not print info for icm support addrs * nit * nit * fix wiz stuff * address PR comments * filter based on balance * add unit tests * Update cmd/blockchaincmd/describe.go Co-authored-by: Michael Kaplan <[email protected]> Signed-off-by: felipemadero <[email protected]> * lint --------- Signed-off-by: felipemadero <[email protected]> Co-authored-by: Michael Kaplan <[email protected]>
* prompt addresses * fix lint * fix lint * fix lint * fix lint * add flags * adding teleporter contract to genesis * validator prompt * bootstrap validators * add mock * fix lint * update prompt validator * update prompt validator * fixes for icm on genesis * add icm from a given embedded file * add function to deploy ICM registry * creating mapping values * add consts * make local deploy to work * do not print info for icm support addrs * nit * implement prompts * fix prompt mock * update sidecar * update prompts * update prompts * refactor * nit * update prompts * fix wiz stuff * update prompts * use default balance and weight * generate new node ids and bls * fix lint * add flags * add flags * add a function to initialize PoA manager * add lib folder * address comments * address comments * address comments * move validator prompt to deploy * address comments * address comments * fix lint * address comments * address comments * fix test * address PR comments * basic PoA manager setting * lint * address comments * fix lint * fix e2e * fix merge * fix merge * filter based on balance * add unit tests * nit * address PR comments * Update cmd/blockchaincmd/describe.go Co-authored-by: Michael Kaplan <[email protected]> Signed-off-by: felipemadero <[email protected]> * nit * address PR comments * lint --------- Signed-off-by: sukantoraymond <[email protected]> Signed-off-by: felipemadero <[email protected]> Co-authored-by: Raymond Sukanto <[email protected]> Co-authored-by: Michael Kaplan <[email protected]>
* wip * go mod tidy * use awm-relayer@main * fixes * use latest awm-relayer pkg which caused upgrade on coreth and avago - has to be resolved * use latest anr and rm prometheus metrics * check for errors * lint * mv to sdk/interchain * some refactoring and added unittests * fix license * fix unittest for now * fix lint * allow empty subnetID add usage working example * rm error msg from example * refactor to address felipe feedback * we should remove this from the test in favour of https://github.com/ava-labs/awm-relayer/blob/main/signature-aggregator/aggregator/aggregator_test.go - we just use exposed API * update readme example * rm goconst fix CI * put `- goconst` back * resolve conficts --------- Co-authored-by: Raymond Sukanto <[email protected]>
* use latest anr main * tidy * bump e2e avago version to be dynamic fee compatible * fix e2e for dynamic fees * lint
* put getClusterBootstrapValidators back * lint * add remore cluster helper for signature aggr * lint
Signed-off-by: sukantoraymond <[email protected]>
* print all errors * e2e acp77 * update test * update test * update test * fix merge * fix merge * fix test * fix lint * update test * update test * fix ci * update flags * update tests * update test * update test * update test * update test * update test * update tests * Acp77 e2e etna add remove validator flow (#2290) * etna devnet add remove validator * add remove validator * fixes * fix * get blockchain ID from output * more fixes * lint * add key * add sov validator e2e on linux only * fix typo * use macosx becuse of the avalanchego poc.5 binary in the assets * fix test * update test --------- Signed-off-by: sukantoraymond <[email protected]> Co-authored-by: arturrez <[email protected]>
Signed-off-by: sukantoraymond <[email protected]>
* fix for meag env to work * lint * fix * use anr without issue * use anr main * improve checks and inconsistency management * fix lint
* wip * added blockchain status support fix typos * address raymond feedback * improve ux * Your blockchain
* validator manager sdk * fix lint * fix lint * remove duplicate code * fix description * update test * complete test * lint * lint * lint * lint * lint
* increase health timeout after network restart * fix unit tests * fix keys e2e * nits * nit * nit * fix e2e
Signed-off-by: sukantoraymond <[email protected]>
* use network instead of cluster * replace clustername with network * update test * fix test * fix test * fix lint * fix lint * fix test * fix lint * fix test * fix lint * address comments * fix lint * address comments * fix lint
a1c5f72
to
ea37fed
Compare
Signed-off-by: sukantoraymond <[email protected]>
* fix contexts and signals * add fuji cluster * lint * point to anr main * address PR comments * remove unused function * address PR comments * add flags for partial sync to local and remote * fix panic * fix e2e
* update tag * update relayer * update tag * fixes --------- Signed-off-by: sukantoraymond <[email protected]> Co-authored-by: Felipe Madero <[email protected]>
Base PR for all ACP 77 related PRs to be merged into