feat: triedb.Config
support for arbitrary backend implementations
#70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allow
ava-labs/coreth
to use arbitrarytriedb
database implementations.How this works
Introduces
HashBackend
andPathBackend
interfaces thattriedb.Database
type-asserts to instead ofhashdb.Database
andpathdb.Backend
respectively. Other interfaces are introduced to avoid having to modify{hash,path}db.Database.Reader()
return values.The explicit
DBOverride
field means that we don't have to modify any of thetriedb
constructor beyond adding a single line immediately before the return. This leaves all modifications of original files entirely mechanistic. This is, however, at the expense of compile-time guarantees of the overriding database being either aHashBackend
or aPathBackend
.How this was tested
Unit test demonstrating override + plumbing.