Succint Header Change #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leouarz
approved these changes
Oct 31, 2023
Leouarz
reviewed
Oct 31, 2023
| commitment: 'KateCommitment', | ||
| appLookup: 'DataLookup' | ||
| appLookup: 'DataLookup', | ||
| commitment: 'KateCommitment' | ||
| }, | ||
| VTHeaderExtension: { |
There was a problem hiding this comment.
Should it be changed too ? Just for the sake of completion ?
There was a problem hiding this comment.
Both Kate Commitment and Header Extension needed change? @kroos47
There was a problem hiding this comment.
Its being done in another place where types are overriden
0xSasaPrsic
reviewed
Oct 31, 2023
| @@ -49674,12 +49674,12 @@ export const typesBundle = { | |||
| "KateCommitment": { | |||
| "rows": "Compact<u16>", | |||
| "cols": "Compact<u16>", | |||
| "commitment": "Vec<u8>", | |||
There was a problem hiding this comment.
was this missing, I don't see that order was changed?
| @@ -28,7 +28,7 @@ const DEFAULT_PARAMS: InflationParams = { | |||
| }; | |||
|
|
|||
| const CERE_NETWORK_INFLATION_PARAMS = { ...DEFAULT_PARAMS, maxInflation: 0.05, minInflation: 0.0001, stakeTarget: 0.2 }; | |||
| const AVAIL_NETWORK_INFLATION_PARAMS = { ...DEFAULT_PARAMS, minInflation: 0.01, maxInflation: 0.05 } | |||
| const AVAIL_NETWORK_INFLATION_PARAMS = { ...DEFAULT_PARAMS, maxInflation: 0.05, minInflation: 0.01 }; | |||
| commitment: 'KateCommitment', | ||
| appLookup: 'DataLookup' | ||
| appLookup: 'DataLookup', | ||
| commitment: 'KateCommitment' | ||
| }, | ||
| VTHeaderExtension: { |
There was a problem hiding this comment.
Both Kate Commitment and Header Extension needed change? @kroos47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.