-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update avail-core
dep
#243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, things are cleaner in some cases now 👍 I guess we have to remove licence from this PR since we have to check dependencies. Also can we move version check change to separate PR and remove spec_version check there also?
Also, it would be great to split dprint changes into separate PR to be able to merge it before anything else, and avoid conflicts later. |
Dprint changes have been moved to #249 |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 26.27% 25.09% -1.19%
==========================================
Files 22 22
Lines 6153 6377 +224
==========================================
- Hits 1617 1600 -17
- Misses 4536 4777 +241
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side, except that expect (:D). I guess this will be squash merge so we could loose reasoning behind version and metadata check change, so if possible, we can do that in two commits or add a comment in the code.
avail-core
dep.dprint
to formattoml
andmd
files.Companion PRs