Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update avail-core dep #243

Merged
merged 10 commits into from
Aug 4, 2023
Merged

Update avail-core dep #243

merged 10 commits into from
Aug 4, 2023

Conversation

fmiguelgarcia
Copy link
Contributor

@fmiguelgarcia fmiguelgarcia commented Jul 25, 2023

  • Add new shared/common avail-core dep.
  • Uses dprint to format toml and md files.

Companion PRs

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@aterentic-ethernal aterentic-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, things are cleaner in some cases now 👍 I guess we have to remove licence from this PR since we have to check dependencies. Also can we move version check change to separate PR and remove spec_version check there also?

@aterentic-ethernal
Copy link
Contributor

Also, it would be great to split dprint changes into separate PR to be able to merge it before anything else, and avoid conflicts later.

@fmiguelgarcia
Copy link
Contributor Author

Also, it would be great to split dprint changes into separate PR to be able to merge it before anything else, and avoid conflicts later.

Dprint changes have been moved to #249
att. @aterentic-ethernal

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Patch coverage: 44.68% and project coverage change: -1.19% ⚠️

Comparison is base (0900dd2) 26.27% compared to head (87e9711) 25.09%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   26.27%   25.09%   -1.19%     
==========================================
  Files          22       22              
  Lines        6153     6377     +224     
==========================================
- Hits         1617     1600      -17     
- Misses       4536     4777     +241     
Files Changed Coverage Δ
src/data.rs 20.20% <0.00%> (-5.64%) ⬇️
src/main.rs 0.42% <0.00%> (ø)
src/network/client.rs 0.00% <0.00%> (ø)
src/subscriptions.rs 0.00% <0.00%> (ø)
src/types.rs 19.51% <0.00%> (+0.17%) ⬆️
src/rpc.rs 30.13% <16.66%> (+0.51%) ⬆️
src/sync_client.rs 44.02% <18.18%> (-0.27%) ⬇️
src/app_client.rs 39.39% <44.44%> (+0.51%) ⬆️
src/utils.rs 16.94% <79.31%> (+1.34%) ⬆️
src/light_client.rs 61.60% <83.33%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aterentic-ethernal aterentic-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side, except that expect (:D). I guess this will be squash merge so we could loose reasoning behind version and metadata check change, so if possible, we can do that in two commits or add a comment in the code.

src/utils.rs Outdated Show resolved Hide resolved
@fmiguelgarcia fmiguelgarcia added the enhancement New feature or request label Aug 4, 2023
@fmiguelgarcia fmiguelgarcia merged commit 439f201 into main Aug 4, 2023
1 check passed
@fmiguelgarcia fmiguelgarcia deleted the miguel/nalgebra_dep branch August 4, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants