Fusion mvp #665
Draft
Fusion mvp #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let pool = pool_opt.as_mut().ok_or(Error::<T>::PoolNotFound)?; | ||
|
|
||
| // If the caller is not root, ensure it's the nominator of the pool | ||
| if let Some(caller) = who { |
There was a problem hiding this comment.
better naming is needed.
There was a problem hiding this comment.
It's a bit unclear what's going on here.
let is_root = ensure_root(origin.clone()).is_ok();
let who = if is_root {
None
} else {
Some(ensure_signed(origin)?)
};
if let Some(caller) = who {
ensure!(Some(&caller) == pool.nominator.as_ref(), Error::<T>::NotAuthorized);
} I will come up with a better option when I am done reviewing
There was a problem hiding this comment.
root can do whatever, if it's a regular address, only nominator can change nominations
| targets: BoundedVec<T::AccountId, T::MaxTargets>, | ||
| ) -> DispatchResult { | ||
| // Check if the origin is root, if not, check if it's a signed origin. | ||
| let is_root = ensure_root(origin.clone()).is_ok(); |
There was a problem hiding this comment.
Why would the root want to force a different target set for pools?
There was a problem hiding this comment.
Nominator for a pool is optional, for all regular pools, we use root, else the guy need to be nominator
ToufeeqP
reviewed
Sep 27, 2024
ToufeeqP
reviewed
Sep 27, 2024
ToufeeqP
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces: