Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop/codeclimate to run with target ruby 3.2 and rails 7.0 #5183

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .codeclimate.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
prepare:
fetch: # Pinned to bixby 2.0.0
- url: "https://raw.githubusercontent.com/samvera-labs/bixby/394ba20eac3f3c8146a679b1dc45c3513074848c/bixby_default.yml"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted

fetch:
- url: "https://raw.githubusercontent.com/samvera/bixby/v5.0.2/bixby_default.yml"
path: "bixby_default.yml"
- url: "https://raw.githubusercontent.com/samvera-labs/bixby/394ba20eac3f3c8146a679b1dc45c3513074848c/bixby_rails_enabled.yml"
- url: "https://raw.githubusercontent.com/samvera/bixby/v5.0.2/bixby_rails_enabled.yml"
path: "bixby_rails_enabled.yml"
- url: "https://raw.githubusercontent.com/samvera-labs/bixby/394ba20eac3f3c8146a679b1dc45c3513074848c/bixby_rspec_enabled.yml"
- url: "https://raw.githubusercontent.com/samvera/bixby/v5.0.2/bixby_rspec_enabled.yml"
path: "bixby_rspec_enabled.yml"
engines:
brakeman:
Expand All @@ -22,7 +22,7 @@ engines:
enabled: false
rubocop:
enabled: true
channel: rubocop-0-50
channel: rubocop-1-48-1
config:
file: .rubocop.cc.yml
checks:
Expand Down
4 changes: 2 additions & 2 deletions .rubocop.cc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ inherit_from:
- bixby_default.yml

AllCops:
TargetRubyVersion: 2.4
TargetRailsVersion: 5.1
TargetRubyVersion: 3.2
TargetRailsVersion: 7.0
DisplayCopNames: true
Exclude:
- 'db/**/*'
Expand Down
4 changes: 2 additions & 2 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ inherit_gem:
bixby: bixby_default.yml

AllCops:
TargetRubyVersion: 2.4
TargetRailsVersion: 5.1
TargetRubyVersion: 3.2
TargetRailsVersion: 7.0
DisplayCopNames: true
Exclude:
- 'db/**/*'
Expand Down