Adjust non-media item filtering in ffprobe #6023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In QA it was found that a video was improperly processed as audio. This was a result of keying off display aspect ratio to filter out non-audio/video items, under the false assumption that all videos would have a display aspect ratio. Explicitly filtering out plain text files and using frame count to filter images will hopefully be more consistent.
masaball
force-pushed
the
video_check
branch
from
30ffcff
to
91f5b88
Compare
masaball
force-pushed
the
video_check
branch
from
8ccdbf5
to
3b2cf57
Compare
cjcolvar
reviewed
Sep 13, 2024
Co-authored-by: Chris Colvard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In QA it was found that a video was improperly processed as audio. This was a result of keying off display aspect ratio to filter out non-audio/video items, under the false assumption that all videos would have a display aspect ratio.
Using Marcel, we can check the file mimetype before feeding it into ffprobe and filter out non-audio/video files.
Related issue: #5762