RavenDB-21665 Cannot change compression level, algo type nor 'direct …

…upload' for server-wide backup
aviv86 · Nov 8, 2023 · b5cd580 · b5cd580
1 parent 54cda9f
commit b5cd580
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 5 deletions.
diff --git a/src/Raven.Studio/typescript/models/database/tasks/periodicBackup/snapshot.ts b/src/Raven.Studio/typescript/models/database/tasks/periodicBackup/snapshot.ts
@@ -45,17 +45,17 @@ class snapshot {
         this.compressionLevel(option);
     }
 
-    useAlgorightm(option: string) {
+    useAlgorithm(option: string) {
         this.compressionAlgorithm(option);
     }
 
     toDto(): Raven.Client.Documents.Operations.Backups.SnapshotSettings {
         const compressionLevel = snapshot.compressionLevelDictionary.find(x => x.name === this.compressionLevel());
-        const compressionAlgorighm = snapshot.compressionAlgorithmDictionary.find(x => x.name === this.compressionAlgorithm());
+        const compressionAlgorithm = snapshot.compressionAlgorithmDictionary.find(x => x.name === this.compressionAlgorithm());
 
         return {
             CompressionLevel: compressionLevel.fullName,
-            CompressionAlgorithm: compressionAlgorighm.fullName,
+            CompressionAlgorithm: compressionAlgorithm.fullName,
             ExcludeIndexes: this.excludeIndexes()
         }
     }

diff --git a/src/Raven.Studio/wwwroot/App/views/database/tasks/editPeriodicBackupTask.html b/src/Raven.Studio/wwwroot/App/views/database/tasks/editPeriodicBackupTask.html
@@ -68,7 +68,7 @@
                                 <span class="caret"></span>
                             </button>
                             <ul class="dropdown-menu" data-bind="foreach: compressionAlgorithmOptions">
-                                <li><a href="#" data-bind="text: $data, click: $parent.useAlgorightm.bind($parent, $data)"></a></li>
+                                <li><a href="#" data-bind="text: $data, click: $parent.useAlgorithm.bind($parent, $data)"></a></li>
                             </ul>
                         </div>
                     </div>

diff --git a/src/Raven.Studio/wwwroot/App/views/manage/editServerWideBackup.html b/src/Raven.Studio/wwwroot/App/views/manage/editServerWideBackup.html
@@ -30,6 +30,20 @@
                     </ul>
                 </div>
             </div>
+            <div class="row margin-bottom">
+                <label class="control-label col-sm-4 col-lg-2">Backup Upload Mode</label>
+                <div class="col-sm-4">
+                    <div class="dropdown btn-block">
+                        <button class="btn btn-block dropdown-toggle text-left" type="button" data-toggle="dropdown">
+                            <span data-bind="text: backupUploadMode"></span>
+                            <span class="caret"></span>
+                        </button>
+                        <ul class="dropdown-menu" data-bind="foreach: backupUploadModes">
+                            <li><a href="#" data-bind="text: $data, click: $parent.useBackupUploadMode.bind($parent, $data)"></a></li>
+                        </ul>
+                    </div>
+                </div>
+            </div>
             <div class="row margin-bottom" data-bind="validationElement: backupType">
                 <label class="control-label col-sm-4 col-lg-2">Backup Type <i class="required"></i> <small><i class="backup-info icon-info text-info"></i></small></label>
                 <div class="col-sm-4" data-bind="validationOptions: { insertMessages: false }">
@@ -47,7 +61,21 @@
             </div>
             <div data-bind="collapse: isSnapshot, with: snapshot">
                 <div class="row margin-bottom">
-                    <label class="control-label col-sm-4 col-lg-2">Compression</label>
+                    <label class="control-label col-sm-4 col-lg-2">Compression Algorithm</label>
+                    <div class="col-sm-4">
+                        <div class="dropdown btn-block">
+                            <button class="btn btn-block dropdown-toggle text-left" type="button" data-toggle="dropdown">
+                                <span data-bind="text: compressionAlgorithm"></span>
+                                <span class="caret"></span>
+                            </button>
+                            <ul class="dropdown-menu" data-bind="foreach: compressionAlgorithmOptions">
+                                <li><a href="#" data-bind="text: $data, click: $parent.useAlgorithm.bind($parent, $data)"></a></li>
+                            </ul>
+                        </div>
+                    </div>
+                </div>
+                <div class="row margin-bottom">
+                    <label class="control-label col-sm-4 col-lg-2">Compression Level</label>
                     <div class="col-sm-4">
                         <div class="dropdown btn-block">
                             <button class="btn btn-block dropdown-toggle text-left" type="button" data-toggle="dropdown">