Better diagnostics (#88)

better diagnostics
lift some dependencies

README.md

@@ -79,6 +79,11 @@ See the docs for more information, including schema-versioning: https://docs.rs/
 
 # Changelog
 
+## 0.18.2
+
+Better diagnostics for async functions with reference parameters. 
+Also, upgrading some dependencies.
+
 ## 0.18.1
 
 Minor improvements to documentation.
@@ -88,7 +93,7 @@ Minor improvements to documentation.
 WARNING! When it comes to savefile-abi calls, 0.18.x is not fully binary compatible with 0.17.x. For
 regular data serialization, there should be no incompatibility.
 
-The major new feature in 0.18.1 is the support for returning boxed futures in SavefileAbi, and support
+The major new feature in 0.18 is the support for returning boxed futures in SavefileAbi, and support
 for the #[async_trait] attribute macro.
 
 This allows exposing async API:s more easily using SavefileAbi.

savefile-abi-min-lib/Cargo.toml

@@ -10,4 +10,4 @@ savefile-abi = { path = "../savefile-abi" }
 savefile-derive = {path = "../savefile-derive"}
 tokio = { version = "1.40", features=["macros", "rt-multi-thread", "time"] }
 tokio-util="0.7"
-async-trait = "0.1"
+async-trait = "=0.1.83"

savefile-abi/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "savefile-abi"
-version = "0.18.1"
+version = "0.18.2"
 edition = "2021"
 authors = ["Anders Musikka <[email protected]>"]
 documentation = "https://docs.rs/savefile-abi/"
@@ -17,8 +17,8 @@ keywords = ["dylib", "dlopen", "ffi"]
 license = "MIT/Apache-2.0"
 
 [dependencies]
-savefile = { path="../savefile", version = "=0.18.1" }
-savefile-derive = { path="../savefile-derive", version = "=0.18.1" }
+savefile = { path="../savefile", version = "=0.18.2" }
+savefile-derive = { path="../savefile-derive", version = "=0.18.2" }
 byteorder = "1.4"
 libloading = "0.8"
 
@@ -31,4 +31,4 @@ rust1_78=[]
 async-trait = "0.1"
 
 [build-dependencies]
-rustc_version="0.2"
+rustc_version="0.4"

savefile-abi/src/lib.rs

@@ -604,13 +604,14 @@ impl TraitObject {
         }
     }
     /// Convert the given fat pointer to a TraitObject instance.
+    #[inline]
     pub fn new_from_ptr<T: ?Sized>(raw: *const T) -> TraitObject {
-        assert_eq!(
+        debug_assert_eq!(
             std::mem::size_of::<*const T>(),
             16,
             "TraitObject::new_from_ptr() must only be used with dyn trait, not any other kind of trait"
         );
-        assert_eq!(std::mem::size_of::<TraitObject>(), 16);
+        debug_assert_eq!(std::mem::size_of::<TraitObject>(), 16);
 
         let mut trait_object = TraitObject::zero();
 
@@ -625,14 +626,15 @@ impl TraitObject {
     }
     /// Note: This only works for boxed dyn Trait.
     /// T must be `dyn SomeTrait`.
+    #[inline]
     pub fn new<T: ?Sized>(input: Box<T>) -> TraitObject {
         let raw = Box::into_raw(input);
-        assert_eq!(
+        debug_assert_eq!(
             std::mem::size_of::<*mut T>(),
             16,
             "TraitObject::new() must only be used with Boxed dyn trait, not any other kind of Box"
         );
-        assert_eq!(std::mem::size_of::<TraitObject>(), 16);
+        debug_assert_eq!(std::mem::size_of::<TraitObject>(), 16);
 
         let mut trait_object = TraitObject::zero();
 
@@ -724,8 +726,9 @@ impl PackagedTraitObject {
     /// T must implement AbiExportable, which means it has an ::ABI_ENTRY associated
     /// type that gives the entry point.
     /// Note, we use `*const T` here even for mutable cases, but it doesn't matter
-    /// since it's never used, it's just cast to other stuff and then finally
+    /// since it's never dereferenced, it's just cast to other stuff and then finally
     /// back to the right type.
+    #[inline]
     pub fn new_from_ptr<T>(r: *const T) -> PackagedTraitObject
     where
         T: AbiExportable + ?Sized,

savefile-derive/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "savefile-derive"
-version = "0.18.1"
+version = "0.18.2"
 authors = ["Anders Musikka <[email protected]>"]
 repository = "https://github.com/avl/savefile"
 rust-version = "1.74"