Fixed support for binary files #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i've fixed support for binary files.
I also did some cleanup, indenting, removed semicolons, changed curly brackets to the same scheme always and i've added an example for browsing local directory in browser with support for view/download files (serve_dir_or_file_from).
There was also an issue with older tree version (i've 1.5.2 here) which i've fixed.
It treats "" as directory, weird but it stopped the serve_dir stuff working.
Additionally i've added character encoding.
There's still an issue with filenames with spaces in it. Maybe will check next week.
Cheers, Frank