test: fix bad validation test (#2915)

avo-hq · Jun 30, 2024 · 5cf66f5 · 5cf66f5
1 parent 7cdc586
commit 5cf66f5
Show file tree

Hide file tree

Showing 21 changed files with 97 additions and 24 deletions.
diff --git a/Appraisals b/Appraisals
@@ -3,6 +3,7 @@
     appraise "rails-#{rails_version}-ruby-#{ruby_version}" do
       gem "psych", "< 4"
       gem "rails", "~> #{rails_version}"
+      gem "activestorage", "~> #{rails_version}"
       gem "ransack", "~> 4.1", ">= 4.1.1"
 
       # source "https://rubygems.pkg.github.com/avo-hq" do

diff --git a/RELEASE.MD b/RELEASE.MD
@@ -1,8 +1,8 @@
 # Release schedule
 
-A new Avo version is released every four-ish weeks, usually on Tuesday. The versioning scheme does not follow semver but a series release.
+A new Avo version is released on the first Tuesday of every month. The versioning scheme does not follow semver but a series release.
 
-The current series is series 3 (version `3.1`, `3.2`, `3.9`, etc). Every second Tuesday of the month we'll increment the minor version number (from `3.7` to `3.8`).
+The current series is series 3 (version `3.1`, `3.2`, `3.9`, etc). Every first Tuesday of the month we'll increment the minor version number (from `3.7` to `3.8`).
 
 ## Patch releases
 

diff --git a/gemfiles/rails_6.1_ruby_3.1.4.gemfile b/gemfiles/rails_6.1_ruby_3.1.4.gemfile
@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "jsbundling-rails"
 gem "cssbundling-rails"
 gem "rails", "~> 6.1"
-gem "activestorage"
+gem "activestorage", "~> 6.1"
 gem "pg", ">= 0.18", "< 2.0"
 gem "puma", "~> 6.4"
 gem "redis", "~> 5.0"
@@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12"
 gem "avo-money_field"
 gem "avo-record_link_field"
 gem "pagy", "> 8"
+gem "csv"
 gem "psych", "< 4"
 
 group :development do
@@ -58,6 +59,7 @@ group :development do
   gem "ripper-tags"
   gem "rubocop-shopify", require: false
   gem "rubycritic", require: false
+  gem "actual_db_schema"
 end
 
 group :test do

diff --git a/gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock b/gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock
@@ -13,7 +13,7 @@ PATH
 PATH
   remote: ..
   specs:
-    avo (3.7.4)
+    avo (3.9.2)
       actionview (>= 6.1)
       active_link_to
       activerecord (>= 6.1)
@@ -99,6 +99,10 @@ GEM
       zeitwerk (~> 2.3)
     acts_as_list (1.1.0)
       activerecord (>= 4.2)
+    actual_db_schema (0.7.5)
+      activerecord (>= 6.0.0)
+      activesupport (>= 6.0.0)
+      csv
     addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
     annotate (3.2.0)
@@ -580,9 +584,10 @@ PLATFORMS
 DEPENDENCIES
   active_link_to
   active_median
-  activestorage
+  activestorage (~> 6.1)
   acts-as-taggable-on!
   acts_as_list
+  actual_db_schema
   addressable
   annotate
   appraisal
@@ -599,6 +604,7 @@ DEPENDENCIES
   chartkick
   countries
   cssbundling-rails
+  csv
   cuprite
   database_cleaner-active_record
   devise

diff --git a/gemfiles/rails_6.1_ruby_3.2.2.gemfile b/gemfiles/rails_6.1_ruby_3.2.2.gemfile
@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "jsbundling-rails"
 gem "cssbundling-rails"
 gem "rails", "~> 6.1"
-gem "activestorage"
+gem "activestorage", "~> 6.1"
 gem "pg", ">= 0.18", "< 2.0"
 gem "puma", "~> 6.4"
 gem "redis", "~> 5.0"
@@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12"
 gem "avo-money_field"
 gem "avo-record_link_field"
 gem "pagy", "> 8"
+gem "csv"
 gem "psych", "< 4"
 
 group :development do
@@ -58,6 +59,7 @@ group :development do
   gem "ripper-tags"
   gem "rubocop-shopify", require: false
   gem "rubycritic", require: false
+  gem "actual_db_schema"
 end
 
 group :test do

diff --git a/gemfiles/rails_6.1_ruby_3.2.2.gemfile.lock b/gemfiles/rails_6.1_ruby_3.2.2.gemfile.lock
@@ -13,7 +13,7 @@ PATH
 PATH
   remote: ..
   specs:
-    avo (3.7.4)
+    avo (3.9.2)
       actionview (>= 6.1)
       active_link_to
       activerecord (>= 6.1)
@@ -99,6 +99,10 @@ GEM
       zeitwerk (~> 2.3)
     acts_as_list (1.1.0)
       activerecord (>= 4.2)
+    actual_db_schema (0.7.5)
+      activerecord (>= 6.0.0)
+      activesupport (>= 6.0.0)
+      csv
     addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
     annotate (3.2.0)
@@ -580,9 +584,10 @@ PLATFORMS
 DEPENDENCIES
   active_link_to
   active_median
-  activestorage
+  activestorage (~> 6.1)
   acts-as-taggable-on!
   acts_as_list
+  actual_db_schema
   addressable
   annotate
   appraisal
@@ -599,6 +604,7 @@ DEPENDENCIES
   chartkick
   countries
   cssbundling-rails
+  csv
   cuprite
   database_cleaner-active_record
   devise

diff --git a/gemfiles/rails_6.1_ruby_3.3.0.gemfile b/gemfiles/rails_6.1_ruby_3.3.0.gemfile
@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "jsbundling-rails"
 gem "cssbundling-rails"
 gem "rails", "~> 6.1"
-gem "activestorage"
+gem "activestorage", "~> 6.1"
 gem "pg", ">= 0.18", "< 2.0"
 gem "puma", "~> 6.4"
 gem "redis", "~> 5.0"
@@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12"
 gem "avo-money_field"
 gem "avo-record_link_field"
 gem "pagy", "> 8"
+gem "csv"
 gem "psych", "< 4"
 
 group :development do
@@ -58,6 +59,7 @@ group :development do
   gem "ripper-tags"
   gem "rubocop-shopify", require: false
   gem "rubycritic", require: false
+  gem "actual_db_schema"
 end
 
 group :test do

diff --git a/gemfiles/rails_6.1_ruby_3.3.0.gemfile.lock b/gemfiles/rails_6.1_ruby_3.3.0.gemfile.lock
@@ -13,7 +13,7 @@ PATH
 PATH
   remote: ..
   specs:
-    avo (3.7.4)
+    avo (3.9.2)
       actionview (>= 6.1)
       active_link_to
       activerecord (>= 6.1)
@@ -99,6 +99,10 @@ GEM
       zeitwerk (~> 2.3)
     acts_as_list (1.1.0)
       activerecord (>= 4.2)
+    actual_db_schema (0.7.5)
+      activerecord (>= 6.0.0)
+      activesupport (>= 6.0.0)
+      csv
     addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
     annotate (3.2.0)
@@ -580,9 +584,10 @@ PLATFORMS
 DEPENDENCIES
   active_link_to
   active_median
-  activestorage
+  activestorage (~> 6.1)
   acts-as-taggable-on!
   acts_as_list
+  actual_db_schema
   addressable
   annotate
   appraisal
@@ -599,6 +604,7 @@ DEPENDENCIES
   chartkick
   countries
   cssbundling-rails
+  csv
   cuprite
   database_cleaner-active_record
   devise

diff --git a/gemfiles/rails_7.1_ruby_3.1.4.gemfile b/gemfiles/rails_7.1_ruby_3.1.4.gemfile
@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "jsbundling-rails"
 gem "cssbundling-rails"
 gem "rails", "~> 7.1"
-gem "activestorage"
+gem "activestorage", "~> 7.1"
 gem "pg", ">= 0.18", "< 2.0"
 gem "puma", "~> 6.4"
 gem "redis", "~> 5.0"
@@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12"
 gem "avo-money_field"
 gem "avo-record_link_field"
 gem "pagy", "> 8"
+gem "csv"
 gem "psych", "< 4"
 
 group :development do
@@ -58,6 +59,7 @@ group :development do
   gem "ripper-tags"
   gem "rubocop-shopify", require: false
   gem "rubycritic", require: false
+  gem "actual_db_schema"
 end
 
 group :test do

diff --git a/gemfiles/rails_7.1_ruby_3.1.4.gemfile.lock b/gemfiles/rails_7.1_ruby_3.1.4.gemfile.lock
@@ -13,7 +13,7 @@ PATH
 PATH
   remote: ..
   specs:
-    avo (3.7.4)
+    avo (3.9.2)
       actionview (>= 6.1)
       active_link_to
       activerecord (>= 6.1)
@@ -114,6 +114,10 @@ GEM
       tzinfo (~> 2.0)
     acts_as_list (1.1.0)
       activerecord (>= 4.2)
+    actual_db_schema (0.7.5)
+      activerecord (>= 6.0.0)
+      activesupport (>= 6.0.0)
+      csv
     addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
     annotate (3.2.0)
@@ -611,9 +615,10 @@ PLATFORMS
 DEPENDENCIES
   active_link_to
   active_median
-  activestorage
+  activestorage (~> 7.1)
   acts-as-taggable-on!
   acts_as_list
+  actual_db_schema
   addressable
   annotate
   appraisal
@@ -630,6 +635,7 @@ DEPENDENCIES
   chartkick
   countries
   cssbundling-rails
+  csv
   cuprite
   database_cleaner-active_record
   devise

diff --git a/gemfiles/rails_7.1_ruby_3.2.2.gemfile b/gemfiles/rails_7.1_ruby_3.2.2.gemfile
@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "jsbundling-rails"
 gem "cssbundling-rails"
 gem "rails", "~> 7.1"
-gem "activestorage"
+gem "activestorage", "~> 7.1"
 gem "pg", ">= 0.18", "< 2.0"
 gem "puma", "~> 6.4"
 gem "redis", "~> 5.0"
@@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12"
 gem "avo-money_field"
 gem "avo-record_link_field"
 gem "pagy", "> 8"
+gem "csv"
 gem "psych", "< 4"
 
 group :development do
@@ -58,6 +59,7 @@ group :development do
   gem "ripper-tags"
   gem "rubocop-shopify", require: false
   gem "rubycritic", require: false
+  gem "actual_db_schema"
 end
 
 group :test do

diff --git a/gemfiles/rails_7.1_ruby_3.2.2.gemfile.lock b/gemfiles/rails_7.1_ruby_3.2.2.gemfile.lock
@@ -13,7 +13,7 @@ PATH
 PATH
   remote: ..
   specs:
-    avo (3.7.4)
+    avo (3.9.2)
       actionview (>= 6.1)
       active_link_to
       activerecord (>= 6.1)
@@ -114,6 +114,10 @@ GEM
       tzinfo (~> 2.0)
     acts_as_list (1.1.0)
       activerecord (>= 4.2)
+    actual_db_schema (0.7.5)
+      activerecord (>= 6.0.0)
+      activesupport (>= 6.0.0)
+      csv
     addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
     annotate (3.2.0)
@@ -611,9 +615,10 @@ PLATFORMS
 DEPENDENCIES
   active_link_to
   active_median
-  activestorage
+  activestorage (~> 7.1)
   acts-as-taggable-on!
   acts_as_list
+  actual_db_schema
   addressable
   annotate
   appraisal
@@ -630,6 +635,7 @@ DEPENDENCIES
   chartkick
   countries
   cssbundling-rails
+  csv
   cuprite
   database_cleaner-active_record
   devise

diff --git a/gemfiles/rails_7.1_ruby_3.3.0.gemfile b/gemfiles/rails_7.1_ruby_3.3.0.gemfile
@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "jsbundling-rails"
 gem "cssbundling-rails"
 gem "rails", "~> 7.1"
-gem "activestorage"
+gem "activestorage", "~> 7.1"
 gem "pg", ">= 0.18", "< 2.0"
 gem "puma", "~> 6.4"
 gem "redis", "~> 5.0"
@@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12"
 gem "avo-money_field"
 gem "avo-record_link_field"
 gem "pagy", "> 8"
+gem "csv"
 gem "psych", "< 4"
 
 group :development do
@@ -58,6 +59,7 @@ group :development do
   gem "ripper-tags"
   gem "rubocop-shopify", require: false
   gem "rubycritic", require: false
+  gem "actual_db_schema"
 end
 
 group :test do