Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor actions controller #2703

Merged
merged 48 commits into from
Oct 9, 2024
Merged

chore: refactor actions controller #2703

merged 48 commits into from
Oct 9, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Apr 18, 2024

Description

Related to #1328

Refactor actions controller

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob marked this pull request as draft April 18, 2024 13:42
@Paul-Bob Paul-Bob self-assigned this Apr 18, 2024
Copy link

codeclimate bot commented Apr 18, 2024

Code Climate has analyzed commit 6ecaf15 and detected 0 issues on this pull request.

View more on Code Climate.

app/helpers/avo/application_helper.rb Outdated Show resolved Hide resolved
lib/avo/configuration.rb Outdated Show resolved Hide resolved
lib/avo/configuration.rb Outdated Show resolved Hide resolved
@@ -160,7 +162,9 @@ def license=(value)
def license
gems = Gem::Specification.map {|gem| gem.name}

@license ||= if gems.include?("avo-advanced")
@license ||= if gems.include?("avo-audits")
"enterprise"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? 😢

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you consider moving the audit feature to the advanced plan?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yorsant.
Apologies for the late reply.

The audit logging feature is, generally speaking, an enterprise feature.

As much as we want to give features away or make them cheaper, we can't do that. It takes a lot of time and effort to build Avo.
We love the self-serve product (Pro, Advanced) but the reality is that we can't survive and improve our business without having some big customers. We've heard from customers that they saved tens and even hundreds of thousands of dollars by using Avo and that they would like to pay more.
If we don't have any Enterprise features, we can't sell Enterprise subscriptions.

This all comes back to us being able to build a robust business and being able to ship more value through our products.

Thanks for asking the question.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW you can build audit log yourself using papertrail and avo resources.

Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label May 12, 2024
@Paul-Bob Paul-Bob removed the Stale label May 13, 2024
lib/tasks/avo_tasks.rake Outdated Show resolved Hide resolved
@Paul-Bob Paul-Bob merged commit 71383ad into main Oct 9, 2024
18 of 21 checks passed
@Paul-Bob Paul-Bob deleted the feature/audit_logs branch October 9, 2024 08:44
@Paul-Bob Paul-Bob changed the title feature: audit logs chore: prepare for audit logging Oct 9, 2024
@Paul-Bob Paul-Bob added Chore and removed Feature Stale exempt Task Something to get done Enterprise labels Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@Paul-Bob Paul-Bob changed the title chore: prepare for audit logging chore: refactor actions controller Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants