-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configuring search_count per resource #2930
Enable configuring search_count per resource #2930
Conversation
e4224b2
to
e3d83ab
Compare
Code Climate has analyzed commit 98f0e65 and detected 0 issues on this pull request. View more on Code Climate. |
@Paul-Bob I think there should be tests for this. However I'm not sure where the search related tests are written. If you could tell me, then I'd be happy to write them. |
It's looking great! Thanks @binarygit
We have some helpers for system tests if you want to go that way. Don't worry about the CI tests I'll have a look, it seems unrelated. |
hey @binarygit. |
Hey adrian. Here’s my email @adrianthedev : [email protected] I’m not in the discord yet! |
@Paul-Bob I added the tests. Let me know what you think 🙏 |
Thank you for the contribution @binarygit ! |
Description
This PR allows setting the search count on a per resource basis. It makes sure that the resource specific count takes precedence over the global configuration.
Fixes #2901
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.