Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: apply target resource policy on belongs_to field create new link #2934

Merged
merged 3 commits into from
Jul 3, 2024
Merged

feature: apply target resource policy on belongs_to field create new link #2934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e472f1
feature: apply target resource policy on belongs_to field create new …
Paul-Bob Jul 3, 2024
8773589
fix polymorphic
Paul-Bob Jul 3, 2024
baccf6f
fix
Paul-Bob Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/components/avo/fields/belongs_to_field/edit_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@
<%= @form.hidden_field @field.id_input_foreign_key %>
<% end %>
<% end %>
<% if field.can_create? %>
<% create_href = create_path(Avo.resource_manager.get_resource_by_model_class(type.to_s)) %>
<% target_resource_for_type = Avo.resource_manager.get_resource_by_model_class(type.to_s) %>
<% if field.can_create?(target_resource_for_type) %>
<% create_href = create_path(target_resource_for_type) %>
<% if !disabled && create_href.present? %>
<%= link_to t("avo.create_new_item", item: type.model_name.human.downcase),
create_href,
Expand Down
8 changes: 6 additions & 2 deletions lib/avo/fields/belongs_to_field.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,12 @@ def index_link_to_record
end
end

def can_create?
@can_create
# field :user, as: :belongs_to, can_create: true
# Only can create when:
# - `can_create: true` option is present
# - target resource's policy allow creation (UserPolicy in this example)
def can_create?(final_target_resource = target_resource)
@can_create && final_target_resource.authorization.authorize_action(:create, raise_exception: false)
end

def form_field_label
Expand Down
Loading