Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: alias close_modal action response to do_nothing #2952

Conversation

G-Simpson
Copy link
Contributor

@G-Simpson G-Simpson commented Jul 7, 2024

Description

Added do_nothing alias for close_modal as described in issue #2944

Fixes #2944

Checklist:

do_nothing

Manual review steps

  1. head to http://localhost:3030/admin/resources/users/new
  2. click "Actions"
  3. click "Do nothing"
  4. click "Run"

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Jul 7, 2024

Code Climate has analyzed commit 37fdae5 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, thanks for looking into it @G-Simpson !

lib/avo/base_action.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @G-Simpson!

@adrianthedev adrianthedev merged commit e10adfb into avo-hq:main Jul 8, 2024
19 of 21 checks passed
@adrianthedev
Copy link
Collaborator

Thank you for your contribution @G-Simpson! This is a cool addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alias close_modal action response to do_nothing
3 participants