Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add visible option to panels #2989

Merged
merged 4 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/avo/resources/items/item_group.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ class Avo::Resources::Items::ItemGroup
include Avo::Concerns::HasItemType
include Avo::Concerns::VisibleItems
include Avo::Concerns::VisibleInDifferentViews
include Avo::Concerns::IsVisible

attr_reader :name
attr_reader :description
Expand All @@ -17,6 +18,7 @@ def initialize(name: nil, description: nil, view: nil, **args)
@description = description
@items_holder = Avo::Resources::Items::Holder.new
@args = args
@visible = args[:visible]

post_initialize if respond_to?(:post_initialize)
end
Expand Down
28 changes: 28 additions & 0 deletions spec/features/avo/tabs_panels_and_sidebar_visibility_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
end
end
end

panel "Hidden panel", visible: -> { resource.record.name == "RSpec PanelVisibility" } do
field :hidden_field_inside_panel, as: :text
end
end
end

Expand Down Expand Up @@ -74,4 +78,28 @@
end
end
end

describe "panels" do
context "when panel should be visible" do
let!(:visible_panel_fields_spouse) { create :spouse, name: "RSpec PanelVisibility" }
let(:url_with_visible_fields) { "/admin/resources/spouses/#{visible_panel_fields_spouse.id}" }

it "displays the field inside the panel" do
visit "/admin/resources/spouses/#{visible_panel_fields_spouse.id}"
expect(page).to have_text "Hidden panel"
expect(page).to have_text "Hidden field inside panel"
end
end

context "when panel should be hidden" do
let!(:not_visible_panel_fields_spouse) { create :spouse }
let(:url_with_not_visible_fields) { "/admin/resources/spouses/#{not_visible_panel_fields_spouse.id}" }

it "does not display the field inside the panel" do
visit url_with_not_visible_fields
expect(page).not_to have_text "Hidden panel"
expect(page).not_to have_text "Hidden field inside panel"
end
end
end
end
Loading