Feature: Run callbacks on through model when detaching association

[binarygit]

Description

Fixes #2512

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

1. Step 1
2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit 14b3980 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

[binarygit]

@Paul-Bob

# team.rb
  has_many :team_members, through: :memberships, class_name: "User", source: :user, inverse_of: :teams

# user.rb
  has_and_belongs_to_many :teams, join_table: :team_memberships, inverse_of: :admin

Here team defines it's team_members assoc using a through table however, User defines the same association as a HABTM.

Detaching a user from the team show page will call team_membership.destroy but because user has setup this assoc as HABTM I don't think when detaching a team from the user's show page should call team_membership.destroy. Am I correct?

Update: Adrian and I talked about this. user.rb should be declaring the relationship as a through relationship. It's unusual to declare a relationship as a through at one end and a HABTM on the other end.

[Paul-Bob]

Update: Adrian and I talked about this. user.rb should be declaring the relationship as a through relationship. It's unusual to declare a relationship as a through at one end and a HABTM on the other end.

Agree, I also noticed that particularity on our dummy recently.

Does this PR work well from both sides if the associations are correctly defined?

[Paul-Bob]

Looking good! Thanks @binarygit, let's please remove the duplicated association and also solve the conflicts.

[binarygit]

Wait. I’m working on displaying the messages when associations are misconfigured

[binarygit]

@Paul-Bob I couldn't find a straightforward way to check if associations are properly configured. Sorry for holding this up, maybe merge this now and I'll pick this up again later.

[binarygit]

I actually talked about this here: https://rubyonrails-link.slack.com/archives/C05054QPL/p1721928807967489 and I don't think verifying associations are setup correctly should be our job.

I did try and it's too much work and also feels like it should be upto the user (like the devs point out in the link) to set it up correctly. WDYT?

[Paul-Bob]

It's ok without the association check @binarygit thanks for looking into it

[adrianthedev]

Looks good.

[Paul-Bob]

It's looking good, thanks @binarygit!