Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tiptap multiple versions of prosemirror-model were loaded #3037

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jul 22, 2024

Description

Pressing Enter key in the Tiptap editor would raise this error:

Uncaught RangeError: Can not convert <> to a Fragment (looks like multiple versions of prosemirror-model were loaded)

Fixes #3035

Fix inspired from ueberdosis/tiptap#577

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added dependencies Pull requests that update a dependency file Fix labels Jul 22, 2024
@Paul-Bob Paul-Bob self-assigned this Jul 22, 2024
Copy link

codeclimate bot commented Jul 22, 2024

Code Climate has analyzed commit c7f24e1 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator

We need to keep an eye on dependencies. For example popper.js uses prosemirror-model, same as tip tap, but they are now different versions. So we are loading both of them.

To visualize this run yarn js:visualize and open the js_bundle_stats.html file in the browser.

@binarygit binarygit merged commit 723c8b6 into main Jul 24, 2024
22 checks passed
@binarygit binarygit deleted the fix/tiptap branch July 24, 2024 07:21
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TipTap issues due to multiple versions of prosemirror-model in dependencies
3 participants