Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: css based solution for sidebar without js dependency #3041

Conversation

G-Simpson
Copy link
Contributor

@G-Simpson G-Simpson commented Jul 22, 2024

Description

Currently the functionality for the show/hide of the sidebar uses 'el-transition' for the sidebare ease-in/out but nothing for the main body. It looks uneven. I've changed them both to use css transitions and have removed some unneccesary code. Works on all viewport sizes

Fixes # No Issue

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Old functionality:
https://github.com/user-attachments/assets/0004757a-f44c-4d13-bdb3-76392d0ee49e

New functionality
https://github.com/user-attachments/assets/4fcef603-1bc1-4f46-a19a-fcfeeb12118f

Manual review steps

Click on the hamburge icon on any viewport size

@github-actions github-actions bot added the Fix label Jul 22, 2024
Copy link

codeclimate bot commented Jul 22, 2024

Code Climate has analyzed commit 1b211b2 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator

This is great @G-Simpson!
The only suggestion I'd have is to make the animation time shorter.

Thank you for this! It's a great improvement!

@G-Simpson G-Simpson changed the title css based solution without js dependency Fix: css based solution for sidebar without js dependency Jul 23, 2024
@G-Simpson G-Simpson marked this pull request as ready for review July 23, 2024 02:23
@binarygit binarygit merged commit 3f083df into avo-hq:main Jul 24, 2024
22 checks passed
@adrianthedev adrianthedev mentioned this pull request Jul 26, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants