pagy v9 compatibility, backwards compatible #3046
Conversation
issue: #3014 pagy upgrade docs: https://ddnexus.github.io/pagy/changelog/#version-900
|
Code Climate has analyzed commit 9180256 and detected 0 issues on this pull request. View more on Code Climate. |
Gemfile
Outdated
| @@ -185,6 +185,6 @@ gem "avo-money_field" | |||
| gem "avo-record_link_field" | |||
|
|
|||
| # gem "pagy", "< 8.0.0" | |||
| gem "pagy", "> 8" | |||
| gem "pagy", "> 9" | |||
There was a problem hiding this comment.
We don't have to commit the Gemfile changes right now, to ensure that we don't break other apps.
There was a problem hiding this comment.
It's ok, this Gemfiles does not reflect on avo's dependencies, those are specified in avo.gemspec
|
Thank you @yshmarov! |
Paul-Bob
added
dependencies
| @@ -1,5 +1,6 @@ | |||
| require "pagy/extras/trim" | |||
| require "pagy/extras/countless" | |||
| require "pagy/extras/size" | |||
There was a problem hiding this comment.
Let's keep this for now.
I created this issue to use integer sizes in favor of using the array legacy API.
|
This has actually broken my rails application that uses avo. On app startup I get a I can see #3049 there's a change scheduled that removes the need for this PR, can that get prioritised or this PR reverted please? |
|
yup. On it @iainbeeston |
|
Fixed on 3.10.9 |
|
Any chance to backport to 2.x? |
Fixes #3014
pagy upgrade docs: https://ddnexus.github.io/pagy/changelog/#version-900