Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add the ability to clear the file input before form submit #3164 #3193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HenriqueRicardoFigueira

Description

This PR is a simple implementation to remove button for files filed.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

image

simplescreenrecorder-2024-08-24_15.17.30.mp4

Manual review steps

  • Add file on file field
  • Click on remove button for remove file.

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @HenriqueRicardoFigueira thank you for this contribution!

Could we apply the same styles to the clear button that we're using for other fields? Additionally, could we position the button right after the file name to make it more noticeable?

image

Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Sep 25, 2024
@adrianthedev adrianthedev added Stale exempt Help wanted We could use some help with this Good first issue Good for newcomers and removed Stale labels Oct 3, 2024
@adrianthedev
Copy link
Collaborator

@HenriqueRicardoFigueira got any extra bit of time to get this over the finish line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers Help wanted We could use some help with this Stale exempt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants