-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Remove last usage of _reflections in favor of reflect_on_association. #3205
Conversation
- better compatible with newer Rails, since it casts to needed type on its own
I'm not 100% sure the CI failure is related to the change, I have seen same problem in other PR without this change also. 🤔 |
Thanks for looking into this.
I'll have a look. Is this still a draft? |
@Paul-Bob it is draft, since I wasn't able to get passing CI. Code-wise looks ok to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this, @simi!
I've pushed some commits to fill in the missing pieces. It's all set now, and we'll release it next week.
successor to #2927
I'm trying to setup Rails 7.2 for Avo 2.x CI at #3204 as well, but it will probably need more time.