chore: plugin generator #3267
chore: plugin generator #3267
Conversation
|
Code Climate has analyzed commit ec3f6b5 and detected 0 issues on this pull request. View more on Code Climate. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| no_tasks do | ||
| def blank_plugin? = options[:type] == "blank" | ||
| def field_plugin? = options[:type] == "field" |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
| no_tasks do | ||
| def blank_plugin? = options[:type] == "blank" | ||
| def field_plugin? = options[:type] == "field" | ||
| def full_name |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
| file_name | ||
| end | ||
| end | ||
| def name_without_field = full_name["_field"] = "" |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
| end | ||
| end | ||
| def name_without_field = full_name["_field"] = "" | ||
| def full_class_name = full_name.classify |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
| end | ||
| def name_without_field = full_name["_field"] = "" | ||
| def full_class_name = full_name.classify | ||
| def module_name = full_class_name |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
| def name_without_field = full_name["_field"] = "" | ||
| def full_class_name = full_name.classify | ||
| def module_name = full_class_name | ||
| def full_path = Rails.root.join(PATH, full_name).to_s |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
| def full_class_name = full_name.classify | ||
| def module_name = full_class_name | ||
| def full_path = Rails.root.join(PATH, full_name).to_s | ||
| def lib_dir = Rails.root.join(full_path, "lib", full_name).to_s |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
| def module_name = full_class_name | ||
| def full_path = Rails.root.join(PATH, full_name).to_s | ||
| def lib_dir = Rails.root.join(full_path, "lib", full_name).to_s | ||
| def railtie_or_engine = File.exist?("#{lib_dir}/railtie.rb") ? "#{lib_dir}/railtie.rb" : "#{lib_dir}/engine.rb" |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0.
| # Do things while the app boots#{field_code if field_plugin?} | ||
| end | ||
| end | ||
| METHOD |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/ClosingHeredocIndentation: METHOD is not aligned with <<-METHOD.
|
This PR has been marked as stale because there was no activity for the past 15 days. |
Description
This PR will add the plugin generator to Avo
Still to do
app/avo/pluginsdirectory is not autoloaded so Avo is not picking up the pluginBranched from the
refactor/plugin-reworkbranch so merge #3259 first.Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.