Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made TestHelpers include methods from WaitForLoaded #3325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Made TestHelpers include methods from WaitForLoaded #3325

wants to merge 1 commit into from

Commits on Oct 10, 2024

  1. Made TestHelpers include methods from WaitForLoaded 

    Right now many of the test helpers don't work in any other project because they rely on methods from WaitForLoaded and the test helpers crash when they are called. This isn't an issue in the avo project itself because the WaitForLoaded methods are required automatically by the avo test suite. It isn't possible to load WaitForLoaded in projects using the rubygem of avo because files inside the spec directory aren't included (and even if they were it would be a bit weird to load something from `spec/support` in a gem).

To fix this I've moved WaitForLoaded alongside the TestHelpers module and included it from there so the helper methods can be used in other projects.
    @iainbeeston
    iainbeeston committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    29ace07 View commit details
    Browse the repository at this point in the history