Add device address parameter for s390x #4010
Conversation
|
(1/1) Host_RHEL.m8.u10.product_rhel.nographic.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.s390x.io-github-autotest-qemu.boot.s390-virtio: STARTED |
maxujun
force-pushed
the
devno
branch
2 times, most recently
from
e6f0fc6 to
bb0897e
Compare
Signed-off-by: Xujun Ma <[email protected]>
| def __init__(self, busid, bus_type, aobject): | ||
| """bus&ssid&devno, 4 ssid and 65536 device numbers""" | ||
| super(QCSSBus, self).__init__( | ||
| "bus", [["ssid", "devno"], [4, 65536]], busid, bus_type, aobject |
There was a problem hiding this comment.
Well, here only cover ssid and devno, as cssidset fe by default. However, should we cover unusual test scenarios? from the qemu doc
* a virtio-mouse device in a non-standard channel subsystem image::
-device virtio-mouse-ccw,devno=2.0.2222
This would not show up in a standard Linux guest.
The properties for the device would be ``dev_id = "2.0.2222"`` and
``subch_id = "2.0.0000"``.
* a virtio-keyboard device in another non-standard channel subsystem image::
-device virtio-keyboard-ccw,devno=0.0.1234
This would not show up in a standard Linux guest, either, as ``0`` is not
the standard channel subsystem image id.
The properties for the device would be ``dev_id = "0.0.1234"`` and
``subch_id = "0.0.0000"``.we can set cssid value rather than default fe, so how about includes the ssid but set fe by default.
| if device.get_param("addr"): | ||
| del device.params["addr"] | ||
| device.set_param("devno", "fe.%s.%s" % ( | ||
| hex(addr[0])[2:], f"{addr[1]:04x}")) |
There was a problem hiding this comment.
as we can mark sure the ssid only with length 0-3, so hex(addr[0])[2:] can easy transfer to addr[0]
There was a problem hiding this comment.
And for f"{addr[1]:04x}"), of course your can "fe.%s.%4x" and addr[1] to do the same thing. Or just f"fe.{addr[0]}.{addr[1]:4x}"
ID:1360