Add the virtiofs element of openfiles #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccaszhulili
force-pushed
the
virtiofs_openfiles
branch
from
073a0ff to
5ca64de
Compare
iccaszhulili
force-pushed
the
virtiofs_openfiles
branch
2 times, most recently
from
84fc1c2 to
6ac2dcf
Compare
Yingshun
previously approved these changes
Jan 9, 2025
Yingshun
reviewed
Jan 9, 2025
| @@ -77,6 +78,7 @@ class Binary(base.base.LibvirtXMLBase): | |||
| "lock_posix", | |||
| "flock", | |||
| "thread_pool_size", | |||
| "open_files", | |||
There was a problem hiding this comment.
Is it better to rename it to 'openfiles_max'? The naming format needs to be consistent with other variables I think. What do you think?
There was a problem hiding this comment.
@Yingshun Updated. Thanks.
Signed-off-by: Lili Zhu <[email protected]>
iccaszhulili
force-pushed
the
virtiofs_openfiles
branch
from
6ac2dcf to
3984e7d
Compare
Yingshun
approved these changes
Jan 15, 2025
chloerh
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.