QEMU_VM: Add nic_extra_param_types support #4045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heywji
force-pushed
the
add_nic_types_support
branch
8 times, most recently
from
083211b to
e695318
Compare
Add nic_extra_params_type params support for nic_extra_params to optimize virtio-net QEMU cmdline type handling. Signed-off-by: Wenkang Ji <[email protected]>
heywji
force-pushed
the
add_nic_types_support
branch
from
e695318 to
c581aee
Compare
|
@leidwang Hi, Could you please help review this netkvm qemu_vm improvement? I have tested positive and negative logic and kept the original logic that defaults to str. All of that works great for me. |
|
@vivianQizhu Hi, I'm calling you to review this patch as well. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nic_extra_param_types params support for nic_extra_params to optimize virtio-net QEMU cmdline type handling.
ID: 3269
Signed-off-by: wji [email protected]