Add CentOS Stream to distro util

[richtja]

Add CentOS Stream to distro util

Reference: #5667

[mr-avocado]

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

• Bug fixes
• Usability Improvements
• Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

[clebergnu]

The implementation of release() already sets the default value to UNKNOWN_DISTRO_RELEASE. Would you care to explain why this is needed?

[richtja]

This is needed, because I used optional group (\d{1,2})? for the release. But when I am looking at it now, I think the better place will be in self.release(). I will send an update.

[clebergnu]

Hi @richtja ,

Thanks for this. Besides the UNKNOWN_DISTRO_RELEASE question, it'd be nice to add a test such as:

diff --git a/selftests/functional/utils/distro.py b/selftests/functional/utils/distro.py
index be9bca03f..d11f042b4 100644
--- a/selftests/functional/utils/distro.py
+++ b/selftests/functional/utils/distro.py
@@ -53,3 +53,14 @@ class Distro(Test):
             + os.uname().machine.encode()
             + b") version 9 release 1\n",
         )
+
+    def test_centos_stream_9(self):
+        """
+        :avocado: dependency={"type": "podman-image", "uri": "quay.io/centos/centos:stream9"}
+        """
+        self.run_job(
+            "quay.io/centos/centos:stream9",
+            b"Detected distribution: centos-stream ("
+            + os.uname().machine.encode()
+            + b") version 9 release 0\n"
+        )

But, as a new probe, it needs to use an egg built from the actual source code (and not use a released Avocado version). We could simply open an issue to add such a test after 103.0 is released so that we don't forget about it.

[richtja]

Hi @richtja ,

Thanks for this. Besides the UNKNOWN_DISTRO_RELEASE question, it'd be nice to add a test such as:

diff --git a/selftests/functional/utils/distro.py b/selftests/functional/utils/distro.py
index be9bca03f..d11f042b4 100644
--- a/selftests/functional/utils/distro.py
+++ b/selftests/functional/utils/distro.py
@@ -53,3 +53,14 @@ class Distro(Test):
             + os.uname().machine.encode()
             + b") version 9 release 1\n",
         )
+
+    def test_centos_stream_9(self):
+        """
+        :avocado: dependency={"type": "podman-image", "uri": "quay.io/centos/centos:stream9"}
+        """
+        self.run_job(
+            "quay.io/centos/centos:stream9",
+            b"Detected distribution: centos-stream ("
+            + os.uname().machine.encode()
+            + b") version 9 release 0\n"
+        )

But, as a new probe, it needs to use an egg built from the actual source code (and not use a released Avocado version). We could simply open an issue to add such a test after 103.0 is released so that we don't forget about it.

Yes you are right, I will create an issue and prepare the test.

[clebergnu]

LGTM, thanks!