This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
[FIX] Fix style errors in the invoice (#7): #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The invoice lines wrapped text poorly for long line descriptions. The text is now in line with the product name. - The margins for the header and the start of the invoice were pretty large. These have been decreased somewhat. Various other margins and min-heights have also been adjusted. - The bank statement part, if it propagated to the following page, overlapped with the header of that page. The header has been properly separated to a separate template, so that the page and header are not rendered in the same space for PDF reports. - The sum and taxes part of the invoice is forced to stay in one part so it doesn't split on page breaks. Closes avoinsystems#7
Merge branch '9.0' into 7-style-fixes Conflicts: report/report_invoice.xml The diff between this and the last commit contains a lot of whitespace: you might want to use `git diff -w` to ignore whitespace changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text is now in line with the product name.
pretty large. These have been decreased somewhat. Various
other margins and min-heights have also been adjusted.
overlapped with the header of that page. The header has been
properly separated to a separate template, so that the page and
header are not rendered in the same space for PDF reports.
one part so it doesn't split on page breaks.
Closes #7
Example PDF images: