-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for empty statement #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the specifics: are you planning to keep DPSEmpty
? Having an explicit representation of an empty top-level statement shows a different style than the approach you are taking with this PR in service, message, and enum definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement. I still wonder if we should do something about DPSEmpty
being handled differently, but I don't want to block this PR for that.
Typically the top-level needs to be handled differently. I think leaving it for now is fine, but if it can be removed then I think we should remove it in the future. |
This PR adds support for parsing and discarding empty statements in enumerations, messages, and services. As well, this PR removes the "empty" constructors in
DotProtoServicePart
andDotProtoMessagePart
as they're no longer used. This PR resolves issue #257.