Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: contributing: add an 'other guidelines' section for soft guidelines #500

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

nodiscc
Copy link
Member

@nodiscc nodiscc commented Jan 13, 2024

  • these guidelines are only relevant for a small fraction of additions but would significantly increase the number of requirements in the pull request template, so add them in a separate document
  • move the guideline about providing a list of differences for forks to this document
  • ref. General Discussion #33 (comment)

- these guidelines are only relevant for a small fraction of additions but would significantly increase the number of requirements in the pull request template, so add them in a separate document
- move the guideline about providing a list of differences for forks to this document
- ref. #33 (comment)
@nodiscc nodiscc added documentation Improvements or additions to documentation enhancement New feature or request reviewers wanted Awaiting reviews labels Jan 13, 2024
@nodiscc nodiscc mentioned this pull request Jan 13, 2024
Copy link
Collaborator

@Rabenherz112 Rabenherz112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have another two additions. One would for forked projects to actually include that 'forked of' part in their description and that if a project offers binary that the orginal language can be used in platforms. (This might need some rephrasing for clarity)

CONTRIBUTING.md Show resolved Hide resolved
Co-authored-by: Rabenherz112 <[email protected]>
Copy link
Collaborator

@kokomo123 kokomo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as all the necessary changes have been made. This does make sense for further explaination of the guidelines, and clarifying it a bit further for newcomers.

@nodiscc nodiscc removed the reviewers wanted Awaiting reviews label Jan 17, 2024
@nodiscc nodiscc merged commit ae1d1e6 into master Jan 18, 2024
1 check passed
@nodiscc nodiscc deleted the other-guidelines branch January 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants