Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Podman to Platforms #856

Closed
wants to merge 2 commits into from

Conversation

kokomo123
Copy link
Collaborator

This adds podman to the platforms list, so we can add Podman support without it erroring out, ref, #836 I think the description from docker works, I just added from Red Hat to distingush it from Docker. Feel free to suggest a better description!

@kokomo123 kokomo123 added tools Automation and maintenance tools reviewers wanted Awaiting reviews labels Sep 8, 2024
@nodiscc
Copy link
Member

nodiscc commented Sep 8, 2024

Podman should work as a drop-in replacement for Docker for 99 (if not 100) percent of software in the list (Cloud Seeder seems to be the exception, in the opposite way). In fact I have moved all my docker-based services to Podman without any problems. The "correct" platform name would be OCI since those projects in fact provide OCI images. But Docker seems to be what most be people will be looking/search for. Docker setup instructions can easily be ported to Podman, and I guess Podman users will know this, so I'm not in favor of renaming the platform right now.

As for adding the Podman tag, I'm not in favor of adding it for a single (proprietary) software project right now. This would require us to add the Podman platform to all items with the Docker platform.

Other opinions welcome.

@nodiscc nodiscc added documentation Improvements or additions to documentation discussion General discussion and removed documentation Improvements or additions to documentation labels Sep 8, 2024
@nodiscc nodiscc mentioned this pull request Sep 8, 2024
12 tasks
@kokomo123
Copy link
Collaborator Author

kokomo123 commented Sep 8, 2024

Podman should work as a drop-in replacement for Docker for 99 (if not 100) percent of software in the list (Cloud Seeder seems to be the exception, in the opposite way). In fact I have moved all my docker-based services to Podman without any problems. The "correct" platform name would be OCI since those projects in fact provide OCI images. But Docker seems to be what most be people will be looking/search for. Docker setup instructions can easily be ported to Podman, and I guess Podman users will know this, so I'm not in favor of renaming the platform right now.

As for adding the Podman tag, I'm not in favor of adding it for a single (proprietary) software project right now. This would require us to add the Podman platform to all items with the Docker platform.

Other opinions welcome.

I see, I see. yeah that'd be a massive burden to just add the podman tag everywhere, and just for a single software, this change needs to be warranted for multiple software projects. I'll wait for raben and Kier's opinions on this, and of course others.

@Rabenherz112
Copy link
Collaborator

Rabenherz112 commented Sep 9, 2024

I don't have much to add since I haven't personally used Podman and wasn't aware of the whole OCI concept. However, I fully agree with nodiscc's point; changing the platform name from Docker to OCI might be technically correct, but it’s likely to confuse users rather than help, especially those explicitly looking for Docker-related instructions (which will probably be the majority and it will also probably cause issues with the K8S tag if I understand OCI correctly).

Also, adding Podman as a tag and then applying it to all Docker projects seems unnecessary. If nodiscc’s statement about compatibility is true, it would just be redundant information. We could add it as a tag to indicate that specific install instructions for Podman are available, but I'm not a fan of this either, as it's not really the purpose of a platform tag either.

@nodiscc
Copy link
Member

nodiscc commented Sep 9, 2024

Agreed. Closing for now.

@kokomo123
Copy link
Collaborator Author

Thank you guys for your input :) 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion General discussion reviewers wanted Awaiting reviews tools Automation and maintenance tools
Development

Successfully merging this pull request may close these issues.

3 participants