Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending indices functions to accept custom types #43

Merged
merged 9 commits into from
Mar 1, 2024

Conversation

MartinuzziFrancesco
Copy link
Member

@MartinuzziFrancesco MartinuzziFrancesco commented Feb 29, 2024

Mainly addressing #42

@MartinuzziFrancesco
Copy link
Member Author

This also addresses part of #6

@MartinuzziFrancesco MartinuzziFrancesco mentioned this pull request Feb 29, 2024
6 tasks
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 91.81970% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 92.22%. Comparing base (bc941e0) to head (200c077).

Files Patch % Lines
src/utils.jl 0.00% 22 Missing ⚠️
src/compute_kernel.jl 61.90% 16 Missing ⚠️
ext/SpectralIndicesDataFramesExt.jl 66.66% 6 Missing ⚠️
ext/SpectralIndicesYAXArraysExt.jl 75.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   96.32%   92.22%   -4.10%     
==========================================
  Files          12       12              
  Lines         598      900     +302     
==========================================
+ Hits          576      830     +254     
- Misses         22       70      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinuzziFrancesco MartinuzziFrancesco merged commit 4a71c14 into main Mar 1, 2024
3 checks passed
@MartinuzziFrancesco MartinuzziFrancesco deleted the fm/types branch March 1, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify _create_indexfun to create functions that allow custom types
1 participant