Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/pb 743+744 #9669

Draft
wants to merge 87 commits into
base: main
Choose a base branch
from
Draft

Conversation

upsellpl
Copy link

@upsellpl upsellpl commented Sep 7, 2023

Fixes #

Proposed Changes:
1.
2.
3.

Please do not submit PRs with minified CSS or JS files. This is managed at the time of release by the Core Team

Michal Jaworski and others added 27 commits March 23, 2022 17:02
dodanie filtra edd_file_download_method_redirect
Fix negative discount code
PB-707 Naprawić nieprawidłowo zliczające się statystyki w zakładce Ra…
PB-732 Naprawić zliczanie kodów zniżkowych
@upsellpl upsellpl marked this pull request as draft September 7, 2023 13:34
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 194 Bugs
Vulnerability E 8 Vulnerabilities
Security Hotspot E 59 Security Hotspots
Code Smell A 3652 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@@ -107,6 +132,10 @@
do_action( 'edd_settings_tab_bottom', $active_tab );
}

// If the main section was empty and we overrode the view with the next subsection, prepare the section for saving
if ( true === $override ) {
?><input type="hidden" name="edd_section_override" value="<?php echo $section; ?>" /><?php

Check failure

Code scanning / SonarCloud

Endpoints should not be vulnerable to reflected cross-site scripting (XSS) attacks Critical

Change this code to not reflect user-controlled data. See more on SonarCloud
if ( ( empty( $edd_options['purchase_page'] ) || 'trash' == get_post_status( $edd_options['purchase_page'] ) ) && current_user_can( 'edit_pages' ) && ! get_user_meta( get_current_user_id(), '_edd_set_checkout_dismissed' ) ) {
echo '<div class="error">';
echo '<p>' . sprintf( __( 'No checkout page has been configured. Visit <a href="%s">Settings</a> to set one.', 'edd' ), admin_url( 'edit.php?post_type=download&page=edd-settings' ) ) . '</p>';
echo '<p><a href="' . add_query_arg( array( 'edd_action' => 'dismiss_notices', 'edd_notice' => 'set_checkout' ) ) . '">' . __( 'Dismiss Notice', 'edd' ) . '</a></p>';

Check failure

Code scanning / SonarCloud

Endpoints should not be vulnerable to reflected cross-site scripting (XSS) attacks Critical

Change this code to not reflect user-controlled data. See more on SonarCloud
echo '<div class="error">';
echo '<p>' . __( 'Your site appears to be blocking the WordPress ajax interface. This may causes issues with your store.', 'edd' ) . '</p>';
echo '<p>' . sprintf( __( 'Please see <a href="%s" target="_blank">this reference</a> for possible solutions.', 'edd' ), 'https://easydigitaldownloads.com/docs/admin-ajax-blocked' ) . '</p>';
echo '<p><a href="' . add_query_arg( array( 'edd_action' => 'dismiss_notices', 'edd_notice' => 'admin_ajax_inaccessible' ) ) . '">' . __( 'Dismiss Notice', 'edd' ) . '</a></p>';

Check failure

Code scanning / SonarCloud

Endpoints should not be vulnerable to reflected cross-site scripting (XSS) attacks Critical

Change this code to not reflect user-controlled data. See more on SonarCloud
echo '<p>' . sprintf( __( 'The Easy Digital Downloads .htaccess file is missing from <strong>%s</strong>!', 'edd' ), edd_get_upload_dir() ) . '</p>';
echo '<p>' . sprintf( __( 'First, please resave the Misc settings tab a few times. If this warning continues to appear, create a file called ".htaccess" in the <strong>%s</strong> directory, and copy the following into it:', 'edd' ), edd_get_upload_dir() ) . '</p>';
echo '<p><pre>' . edd_get_htaccess_rules() . '</pre>';
echo '<p><a href="' . add_query_arg( array( 'edd_action' => 'dismiss_notices', 'edd_notice' => 'htaccess_missing' ) ) . '">' . __( 'Dismiss Notice', 'edd' ) . '</a></p>';

Check failure

Code scanning / SonarCloud

Endpoints should not be vulnerable to reflected cross-site scripting (XSS) attacks Critical

Change this code to not reflect user-controlled data. See more on SonarCloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants