Added Timeout Configuration #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween calls Added configuration option so that users can customize the timeout between calls Added Tiemout option Added Timeout Option Added Timeout Option Configuration
jirkafajfr
reviewed
Jan 27, 2025
|
|
||
| if (isNaN(timeout) || (timeout < 0)) { | ||
| timeout = 1000; | ||
| setDefaultAutoSelectFamilyAttemptTimeout(timeout); |
There was a problem hiding this comment.
Would you mind adding unit tests that tests this functionality?
| @@ -16,6 +16,12 @@ inputs: | |||
| description: '(Optional) Transforms environment variable name. Options: uppercase, lowercase, none. Default value: uppercase.' | |||
| required: false | |||
| default: 'uppercase' | |||
| auto-select-family-attempt-timeout: | |||
| description: '(Optional) Timeout in milliseconds for each attempt to retrieve a secret from a secret family. Default value: 1000' | |||
There was a problem hiding this comment.
This is node documentation talking about autoSelectFamily. Would you mind trying to use it as base for the description of this field (and documentation). Try to summarize what it does and when should customer use it (also you have typo in select family vs secret family).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added the option for users to let there be a timeout after each call. Default is set to 1 second
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.