Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apollo): Fix using Apollo to connect to AppSync in China #2947

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #2945

Description of changes:
In China the AppSync URL has .cn as a TLD, and we weren't account for that in our standard URL regex. I updated the regex to match Amplify JS

How did you test these changes?
Unit test

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner November 14, 2024 16:35
@mattcreaser mattcreaser merged commit 59bde4e into main Nov 15, 2024
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/apollo-extensions-china branch November 15, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants