Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow input wiring for deprecate_release and restore_release workflows #1311

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

edwardfoyle
Copy link
Contributor

@edwardfoyle edwardfoyle commented Apr 16, 2024

Problem

When testing these workflows before merging, there was no way to kick off the workflow using the GH UI so I was manually setting these env vars in the branch push workflow. I thought they would be set automatically by the workflow inputs, but they are not.

Issue number, if available:

Changes

Wire the workflow inputs to corresponding environment variables so they are picked up by the @actions/core toolkit getInput() function.

Corresponding docs PR, if applicable:

Validation

Now that the workflow exists on main, the workflow dispatch UI can be used to trigger the workflow:

Successful dryrun restore_release workflow: https://github.com/aws-amplify/amplify-backend/actions/runs/8710549954/job/23892707554
Successful dryrun deprecate_release workflow: https://github.com/aws-amplify/amplify-backend/actions/runs/8710626570/job/23892943477

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: 145a464

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@edwardfoyle edwardfoyle enabled auto-merge (squash) April 16, 2024 18:37
@edwardfoyle edwardfoyle merged commit 28a0a61 into main Apr 16, 2024
29 checks passed
@edwardfoyle edwardfoyle deleted the input-wiring branch April 16, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants